[rcore] Fix FileMove from delete file if FileCopy did not work#5806
Merged
raysan5 merged 1 commit intoraysan5:masterfrom Apr 26, 2026
Merged
[rcore] Fix FileMove from delete file if FileCopy did not work#5806raysan5 merged 1 commit intoraysan5:masterfrom
raysan5 merged 1 commit intoraysan5:masterfrom
Conversation
Owner
|
@Lucrecious Wow! Good catch! It will be updated for new release 6.1 or 6.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I was making a file browser in my favourite graphics library (raylib), and needed file move functionality.
The issue was that despite the function running and leaving no errors, it was deleting my file instead of moving it!
I noticed that
FileCopyseems to return1ifSaveFileDatareturnstrueand0otherwise, but some otherFileXfunctions return0if the operation succeeds - so I wasn't sure what to fix!FileCopysupposed return0if it succeeds or1for success but the bug is inFileMove?Anyway, I went with the solution that preserves backwards compatibility and assumes that
FileCopycannot change what it returns until... 7.0?