Fix signed integer overflow in GetCurrentMonitor distance calc#5842
Open
Vasilis-Narain wants to merge 1 commit intoraysan5:masterfrom
Open
Fix signed integer overflow in GetCurrentMonitor distance calc#5842Vasilis-Narain wants to merge 1 commit intoraysan5:masterfrom
Vasilis-Narain wants to merge 1 commit intoraysan5:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GetCurrentMonitor()inrcore_desktop_glfw.ccomputesint dist = dx*dx + dy*dywheredx,dyare pixel offsets from window centre to monitor corner. On my setup (multi-monitor WSL2 through Windows 11) the squared sum exceedsINT_MAX, causing signed integer overflow UB. Today GCC wraps silently, but UBSan-instrumented builds (eg. Zig or clang with-fsanitize=undefined) fail.Environment
Repro
Originally caught by Zig 0.16's UBSan trapping on the bundled raylib build:
Reproduced standalone by adding a
printfnext to the overflow site and runningexamples/core/core_basic_window:prod(computed as(long long)dx*dx + (long long)dy*dy) exceedsINT_MAX, confirming the truncation.Fix
Promote
distandclosestDisttolong long. No behavior change for monitors withinINT_MAXdistance and correctly handles cases beyond it without UB.