fix UB in ComputeSHA-1#5957
Merged
Merged
Conversation
Owner
|
@TheFissk Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UB related to integer promotion in
ComputeSHA1.When compiling with UBSans on (like the zig compiler does) unsigned chars are promoted to integers, so any value in
msg> 128 will cause the 32nd bit to be set and technically triggering a signed integer overflow. This shouldn't cause issues in most compilers but it is techincally UB. explicitly casing the msg to an unsigned int fixes the problemthe fastest way to replicate the above issue to run
zig build core_compute_hashand press thecompute input data hashes button