Skip to content

fix(admin): improve webhook form fields#1636

Merged
paanSinghCoder merged 2 commits into
mainfrom
fix/webhook-form-fields
May 21, 2026
Merged

fix(admin): improve webhook form fields#1636
paanSinghCoder merged 2 commits into
mainfrom
fix/webhook-form-fields

Conversation

@paanSinghCoder
Copy link
Copy Markdown
Contributor

@paanSinghCoder paanSinghCoder commented May 20, 2026

  • Swap the raw `<textarea>` in `CustomField` for apsara `TextArea`, with horizontal resize locked.
  • URL field in webhook create + update drawers now uses `variant="input"` instead of `variant="textarea"`.

- Swap raw <textarea> in CustomField for apsara TextArea (picks up
  design-system styling and rows=3 baseline) and lock horizontal
  resize with style={{ resize: "vertical" }}.
- Switch the webhook URL field from variant="textarea" to
  variant="input" in both create and update drawers.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment May 21, 2026 6:37am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b4d23e14-a445-4e97-9b50-27c08332d9d7

📥 Commits

Reviewing files that changed from the base of the PR and between 0b6e31a and 3ebc8e5.

📒 Files selected for processing (3)
  • web/sdk/admin/components/CustomField.tsx
  • web/sdk/admin/views/webhooks/webhooks/create/index.tsx
  • web/sdk/admin/views/webhooks/webhooks/update/index.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Webhook URL input fields changed from multi-line textarea to single-line text input in create and update forms
    • Updated textarea component rendering implementation

Walkthrough

This PR refactors the CustomField component's textarea variant to use Raystack's TextArea component with unified styling, then updates the webhook create and update forms to render their URL fields using the input variant instead of textarea.

Changes

CustomField TextArea and Webhook Form Updates

Layer / File(s) Summary
CustomField textarea component refactoring
web/sdk/admin/components/CustomField.tsx
Import TextArea from Raystack and replace the native <textarea> element with the TextArea component. Merge incoming style prop with resize: "vertical", preserving defaultValue and placeholder behavior.
Webhook form URL field variant updates
web/sdk/admin/views/webhooks/webhooks/create/index.tsx, web/sdk/admin/views/webhooks/webhooks/update/index.tsx
Update the url field in both CreateWebhooks and UpdateWebhooks forms to use variant="input" instead of variant="textarea".

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested Reviewers

  • rohanchkrabrty
  • rsbh
  • rohilsurana
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

coveralls commented May 20, 2026

Coverage Report for CI Build 26209800049

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 42.592%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37953
Covered Lines: 16165
Line Coverage: 42.59%
Coverage Strength: 11.91 hits per line

💛 - Coveralls

@paanSinghCoder paanSinghCoder enabled auto-merge (squash) May 21, 2026 06:37
@paanSinghCoder paanSinghCoder merged commit 98d6246 into main May 21, 2026
8 checks passed
@paanSinghCoder paanSinghCoder deleted the fix/webhook-form-fields branch May 21, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants