Skip to content

fix(admin): improve webhook form fields #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paanSinghCoder merged 2 commits into from
May 21, 2026
Merged

fix(admin): improve webhook form fields #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ebc8e5
fix(admin): improve webhook form fields
paanSinghCoder May 20, 2026
cb63f0d
Merge branch 'main' into fix/webhook-form-fields
paanSinghCoder May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/sdk/admin/components/CustomField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
FormLabel,
FormMessage,
} from "@radix-ui/react-form";
import { Flex, Select, Switch, Text, Input } from "@raystack/apsara-v1";
import { Flex, Select, Switch, Text, TextArea, Input } from "@raystack/apsara-v1";
import React, { CSSProperties } from "react";

import { Control, Controller, UseFormRegister } from "react-hook-form";
Expand Down Expand Up @@ -77,14 +77,14 @@
switch (variant) {
case "textarea": {
return (
<textarea
<TextArea
{...field}
defaultValue={props?.defaultValue}
placeholder={
placeholder ||
`Enter your ${title?.toLowerCase() || name}`
}
style={style}
style={{ ...style, resize: "vertical" }}
/>
);
}
Expand Down Expand Up @@ -157,7 +157,7 @@
}

default: {
const { ref, ...rest } = field;

Check warning on line 160 in web/sdk/admin/components/CustomField.tsx

View workflow job for this annotation

GitHub Actions / JS SDK Lint 

'ref' is assigned a value but never used
return (
<Input
{...rest}
Expand Down
2 changes: 1 addition & 1 deletion web/sdk/admin/views/webhooks/webhooks/create/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export default function CreateWebhooks({ open = false, onClose: onCloseProp }: C
name="url"
register={methods.register}
control={methods.control}
variant="textarea"
variant="input"
style={{ width: "100%" }}
/>
<CustomFieldName
Expand Down
2 changes: 1 addition & 1 deletion web/sdk/admin/views/webhooks/webhooks/update/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export default function UpdateWebhooks({ open = false, webhookId: webhookIdProp,
defaultValue={webhook?.url}
register={methods.register}
control={methods.control}
variant="textarea"
variant="input"
style={{ width: "100%" }}
isLoading={isWebhookLoading}
/>
Expand Down
Loading