fix(sdk): add cursor pointer to breadcrumb items without href#1651
fix(sdk): add cursor pointer to breadcrumb items without href#1651rohilsurana wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughFour detail view components—Personal Access Token, Project, Service Account, and Team—each receive an inline pointer cursor style on their main breadcrumb navigation item. This provides consistent visual feedback across all detail pages to indicate that the breadcrumb is interactive. ChangesBreadcrumb Pointer Cursor Styling
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 26442900351Coverage remained the same at 42.808%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/sdk/react/views-new/teams/team-details-view.tsx (1)
272-272: 💤 Low valueConsider consolidating repeated inline styles.
The
style={{ cursor: 'pointer' }}pattern is repeated identically across four detail views (PAT, Project, Service Account, and Team). While the current approach works, consider these alternatives if this pattern grows:
- Extract to a shared CSS class (e.g.,
.breadcrumb-clickable)- Create a reusable
ClickableBreadcrumbItemwrapper component- Request the apsara library to handle cursor styling internally for breadcrumb items with
onClickFor now, the inline style is acceptable for this small change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 081bef8c-6819-49b4-8c62-ab6e413807a0
📒 Files selected for processing (4)
web/sdk/react/views-new/pat/pat-details-view.tsxweb/sdk/react/views-new/projects/project-details-view.tsxweb/sdk/react/views-new/service-accounts/service-account-details-view.tsxweb/sdk/react/views-new/teams/team-details-view.tsx
Summary
style={{ cursor: 'pointer' }}to clickable breadcrumb items in all detail views (PAT, projects, service accounts, teams)href="#"but the apsaraBreadcrumb.Itemrenders an<a>withouthref, which defaults tocursor: auto(text cursor) instead of pointerTest plan