Skip to content

fix(sdk): add cursor pointer to breadcrumb items without href#1651

Open
rohilsurana wants to merge 1 commit into
mainfrom
pat-sdk-fixes-2
Open

fix(sdk): add cursor pointer to breadcrumb items without href#1651
rohilsurana wants to merge 1 commit into
mainfrom
pat-sdk-fixes-2

Conversation

@rohilsurana
Copy link
Copy Markdown
Member

Summary

  • Add style={{ cursor: 'pointer' }} to clickable breadcrumb items in all detail views (PAT, projects, service accounts, teams)
  • The previous PR removed href="#" but the apsara Breadcrumb.Item renders an <a> without href, which defaults to cursor: auto (text cursor) instead of pointer

Test plan

  • Navigate to any detail page (PAT, project, team, service account) → verify breadcrumb shows pointer cursor on hover
  • Click breadcrumb → verify correct navigation back to list page

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment May 26, 2026 9:03am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Breadcrumb navigation items in personal access token, project, service account, and team detail views now display with a pointer cursor to indicate they are interactive elements.

Walkthrough

Four detail view components—Personal Access Token, Project, Service Account, and Team—each receive an inline pointer cursor style on their main breadcrumb navigation item. This provides consistent visual feedback across all detail pages to indicate that the breadcrumb is interactive.

Changes

Breadcrumb Pointer Cursor Styling

Layer / File(s) Summary
Breadcrumb pointer cursor styling
web/sdk/react/views-new/pat/pat-details-view.tsx, web/sdk/react/views-new/projects/project-details-view.tsx, web/sdk/react/views-new/service-accounts/service-account-details-view.tsx, web/sdk/react/views-new/teams/team-details-view.tsx
Clickable breadcrumb items across all detail views now include style={{ cursor: 'pointer' }} to visually signal interactivity to users.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • raystack/frontier#1646: Related breadcrumb changes across the same detail views; this PR adds pointer cursor styling while the other modifies breadcrumb click handler logic.

Suggested reviewers

  • rsbh
  • Shreyag02
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26442900351

Coverage remained the same at 42.808%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37848
Covered Lines: 16202
Line Coverage: 42.81%
Coverage Strength: 11.98 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
web/sdk/react/views-new/teams/team-details-view.tsx (1)

272-272: 💤 Low value

Consider consolidating repeated inline styles.

The style={{ cursor: 'pointer' }} pattern is repeated identically across four detail views (PAT, Project, Service Account, and Team). While the current approach works, consider these alternatives if this pattern grows:

  • Extract to a shared CSS class (e.g., .breadcrumb-clickable)
  • Create a reusable ClickableBreadcrumbItem wrapper component
  • Request the apsara library to handle cursor styling internally for breadcrumb items with onClick

For now, the inline style is acceptable for this small change.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 081bef8c-6819-49b4-8c62-ab6e413807a0

📥 Commits

Reviewing files that changed from the base of the PR and between f1d968b and 5c9dd53.

📒 Files selected for processing (4)
  • web/sdk/react/views-new/pat/pat-details-view.tsx
  • web/sdk/react/views-new/projects/project-details-view.tsx
  • web/sdk/react/views-new/service-accounts/service-account-details-view.tsx
  • web/sdk/react/views-new/teams/team-details-view.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants