Skip to content

refactor(server): remove unused ListOrganizationsByDomain messages and authz entry#1793

Merged
AmanGIT07 merged 1 commit into
mainfrom
refactor/remove-unused-list-orgs-by-domain
Jul 24, 2026
Merged

refactor(server): remove unused ListOrganizationsByDomain messages and authz entry#1793
AmanGIT07 merged 1 commit into
mainfrom
refactor/remove-unused-list-orgs-by-domain

Conversation

@AmanGIT07

@AmanGIT07 AmanGIT07 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

FrontierService does not define a ListOrganizationsByDomain rpc. Only its request/response messages and an authorization interceptor entry existed. This removes both.

Changes

Technical Details

The large diff in frontier.pb.go is descriptor index renumbering from removing two messages. The only type-level changes are the two removed message structs and their methods.

Test Plan

  • Manual testing completed
  • Build and type checking passes
  • go test ./pkg/server/... ./internal/api/v1beta1connect/... passes
  • Verified via protoreflect that the compiled FrontierService descriptor is unchanged (180 methods; ListOrganizationsByDomain was never among them)

🤖 Generated with Claude Code

…d authz entry

FrontierService does not define a ListOrganizationsByDomain rpc. Remove the
interceptor's authorization entry for it and bump proton to a commit that
drops the unused request/response messages from the generated code.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jul 23, 2026 6:42am

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d834b4c-38be-4e2e-9e19-064108c7057e

📥 Commits

Reviewing files that changed from the base of the PR and between c99f1f8 and c7c8163.

⛔ Files ignored due to path filters (1)
  • proto/v1beta1/frontier.pb.go is excluded by !**/*.pb.go, !proto/**
📒 Files selected for processing (2)
  • Makefile
  • pkg/server/connect_interceptors/authorization.go
💤 Files with no reviewable changes (1)
  • pkg/server/connect_interceptors/authorization.go

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved authorization enforcement for organization lookups by domain. Requests without the required permissions are now denied instead of proceeding without validation.
  • Maintenance
    • Updated the underlying Proton source version used during protobuf generation, improving alignment with the latest supported source revision.

Walkthrough

The PR updates the Proton commit used by the proto Makefile target and removes the ListOrganizationsByDomain authorization-map entry so the interceptor applies its default denial behavior.

Changes

Proton source pin

Layer / File(s) Summary
Update Proton source commit
Makefile
The PROTON_COMMIT pin used to download Proton sources is updated to a newer commit.

Authorization default behavior

Layer / File(s) Summary
Remove procedure exemption
pkg/server/connect_interceptors/authorization.go
ListOrganizationsByDomain is removed from authorizationValidationMap and now follows the interceptor’s default unauthorized response path.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: rohilsurana

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29985851519

Warning

No base build found for commit c99f1f8 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 46.213%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 38535
Covered Lines: 17808
Line Coverage: 46.21%
Coverage Strength: 14.07 hits per line

💛 - Coveralls

@AmanGIT07
AmanGIT07 merged commit ae5e60a into main Jul 24, 2026
10 of 11 checks passed
@AmanGIT07
AmanGIT07 deleted the refactor/remove-unused-list-orgs-by-domain branch July 24, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants