refactor(server): remove unused ListOrganizationsByDomain messages and authz entry#1793
Conversation
…d authz entry FrontierService does not define a ListOrganizationsByDomain rpc. Remove the interceptor's authorization entry for it and bump proton to a commit that drops the unused request/response messages from the generated code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates the Proton commit used by the ChangesProton source pin
Authorization default behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 29985851519Warning No base build found for commit Coverage: 46.213%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Summary
FrontierServicedoes not define aListOrganizationsByDomainrpc. Only its request/response messages and an authorization interceptor entry existed. This removes both.Changes
ListOrganizationsByDomainentry from the authorization interceptor map; procedures missing from the map are denied by default.PROTON_COMMITto raystack/proton@f7f9282, which drops the unusedListOrganizationsByDomainRequest/ListOrganizationsByDomainResponsemessages (refactor(frontier): remove unused ListOrganizationsByDomain messages proton#491).proto/v1beta1/frontier.pb.go.Technical Details
The large diff in
frontier.pb.gois descriptor index renumbering from removing two messages. The only type-level changes are the two removed message structs and their methods.Test Plan
go test ./pkg/server/... ./internal/api/v1beta1connect/...passesFrontierServicedescriptor is unchanged (180 methods;ListOrganizationsByDomainwas never among them)🤖 Generated with Claude Code