chore(proto): pull acknowledge_token_forfeit field for DeleteOrganizationRequest - #1864
chore(proto): pull acknowledge_token_forfeit field for DeleteOrganizationRequest#1864whoAbhishekSah wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Makefile updates ChangesProton dependency pin
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧪 Manual test report: org delete preflightTested the new delete flow end to end against a local server built from the tip of this stack (#1864 proto → #1865 mocks → #1857 preflight). The server was connected to a Stripe test account, so every subscription and invoice below is a real Stripe object, not a mock. How the test environment was set up
Results
Error shapeBlocked deletes return {
"code": "failed_precondition",
"message": "organization cannot be deleted yet: subscription[f1e289ce-...] is active: cancel it, then retry the delete; invoice[c304285d-...] is unpaid: pay it via its hosted payment page, then retry the delete; billing account[5a77db67-...] has 300 unused tokens that deleting the organization forfeits: retry the delete with acknowledge_token_forfeit set to proceed",
"details": [{
"type": "google.rpc.PreconditionFailure",
"violations": [
{ "type": "ACTIVE_SUBSCRIPTION", "subject": "f1e289ce-..." },
{ "type": "UNPAID_INVOICE", "subject": "c304285d-..." },
{ "type": "UNUSED_TOKENS", "subject": "5a77db67-..." }
]
}]
}The structured details reach the caller intact, so the error sanitizer is letting non-internal codes through as intended. Side observation (not from this stack)
|
…tionRequest Generated from raystack/proton@0b8bdb2 (91eaffc + the new field only, so the recent breaking proto changes on proton main stay out of this change). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bbf43fc to
5aebb50
Compare
Part of #1837. Bottom of a 3-PR stack: #this → mocks → pre-flight code (#1857).
Regenerates the vendored protos to pick up the new
bool acknowledge_token_forfeitfield onDeleteOrganizationRequest, added in raystack/proton#497.Note on the
PROTON_COMMITpin: proton main has moved ahead with breaking changes frontier hasn't absorbed yet (CreatePlan/UpdatePlan moved to AdminService). So the pin points atfrontier-pin/org-delete-token-forfeit, which is the previous pin (91eaffc) plus only the new field. A separate task will move frontier onto proton main.The field is unused until the top of the stack.
🤖 Generated with Claude Code