Skip to content

feat(pdf): add --puppeteer-arg option to export command - #21

Merged
rbardini merged 8 commits into
rbardini:mainfrom
kwilliamyoung:main
Sep 19, 2025
Merged

feat(pdf): add --puppeteer-arg option to export command#21
rbardini merged 8 commits into
rbardini:mainfrom
kwilliamyoung:main

Conversation

@kwilliamyoung

Copy link
Copy Markdown
Contributor

Thanks for taking a look, I appreciate the feedback!

@rbardini rbardini left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Happy to merge this, only have a couple requests:

Comment thread src/cli.ts Outdated
Comment thread package.json Outdated
@jakoss

jakoss commented Aug 15, 2025

Copy link
Copy Markdown

Can we push that PR? I'm struggling with the same issue on GitHub Actions :)

@rbardini

Copy link
Copy Markdown
Owner

@kwilliamyoung Would you be able to fix the review comments? Looks like Sade does support repeated options, so a generic --puppeteer-arg should work.

@kwilliamyoung

kwilliamyoung commented Aug 31, 2025 via email

Copy link
Copy Markdown
Contributor Author

@s3rj1k

s3rj1k commented Sep 16, 2025

Copy link
Copy Markdown

Same problem with GHA for me

@codecov-commenter

codecov-commenter commented Sep 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (56df26e) to head (2300645).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          153       157    +4     
  Branches        23        26    +3     
=========================================
+ Hits           153       157    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rbardini

Copy link
Copy Markdown
Owner

@kwilliamyoung I took the liberty of fixing the review comments to unblock the PR, hope you don't mind. Planning to merge and release it later today.

@rbardini rbardini added the enhancement New feature or request label Sep 19, 2025
@rbardini rbardini changed the title Add support for --nosandbox argument to puppeteer to enable support in gitlabCI feat(pdf): add --puppeteer-arg option to export command Sep 19, 2025
@rbardini
rbardini merged commit 6ad140e into rbardini:main Sep 19, 2025
2 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants