RDKBACCL-975 : Provide command line args for iperf3 app - #124
Merged
Conversation
SsandhyaR
marked this pull request as draft
July 28, 2025 13:00
SsandhyaR
marked this pull request as ready for review
July 29, 2025 11:11
Contributor
|
Reviewed it. Looks okay to me. |
Reason for change: made changes to split single argument as multiple arugments for config.json of a bundle Test Procedure: UspPa -c operate "Device.SoftwareModules.InstallDU(URL=http://192.168.2.51/iperf3argsjul255.tar)" UspPa -c operate "Device.SoftwareModules.ExecutionUnit.1.SetRequestedState(RequestedState=Active)" Risks: None Signed-off-by: ssiras826 <ssiras826@cable.comcast.com>
Contributor
|
Looks good but I'll wait until L1&L2 unit tests are fixed ( #125 )and they pass with this change. |
goruklu
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: made changes to split single argument as multiple arugments for config.json of a bundle
Test Procedure: UspPa -c operate "Device.SoftwareModules.InstallDU(URL=http://192.168.2.51/iperf3argsjul255.tar)"
UspPa -c operate "Device.SoftwareModules.ExecutionUnit.1.SetRequestedState(RequestedState=Active)"
Risks: None