Skip to content

[Actions] Fix a bug where baseline would get deleted due to excluding assets - #309

Merged
sebaszm merged 1 commit into
masterfrom
development/actions-deploy-exclude
Jul 24, 2026
Merged

[Actions] Fix a bug where baseline would get deleted due to excluding assets#309
sebaszm merged 1 commit into
masterfrom
development/actions-deploy-exclude

Conversation

@VeithMetro

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 24, 2026 07:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflows that publish generator outputs to gh-pages to prevent the existing raw baseline (master/latest_raw) from being removed during deployment when assets are excluded.

Changes:

  • Removed the exclude_assets: 'master/latest_raw' setting from the primary Deploy to gh-pages step in four generator workflows.
  • Leaves the dedicated “Deploy raw baseline (full replace)” step intact to continue doing a clean replace of master/latest_raw on non-PR runs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/ProxyStubGenerator.yml Stops excluding master/latest_raw during the main deploy step to avoid baseline removal.
.github/workflows/PluginSkeletonGenerator.yml Same adjustment to prevent deleting the raw baseline during preview deploys.
.github/workflows/LuaGenerator.yml Removes the exclusion that could cause the baseline directory to be deleted.
.github/workflows/JsonGenerator.yml Aligns deploy behavior with the fix by no longer excluding the raw baseline path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

LuaGenerator Results

View Results

No changes detected.

@github-actions

Copy link
Copy Markdown

Plugin skeleton preview (latest run):
https://rdkcentral.github.io/ThunderTools/PluginSkeletonGenerator/previews/pr-309/run-30077036301/

No changes detected in generated plugin code. The PR changes are internal to the generator or do not affect output.

@VeithMetro
VeithMetro requested a review from sebaszm July 24, 2026 08:03
@github-actions

Copy link
Copy Markdown

ProxyStubGenerator Results

View Results

No changes detected.

@github-actions

Copy link
Copy Markdown

JsonGenerator Results

View Results

Changes detected.

@sebaszm
sebaszm merged commit 5dca21f into master Jul 24, 2026
196 checks passed
@sebaszm
sebaszm deleted the development/actions-deploy-exclude branch July 24, 2026 08:27
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants