VPLAY-13151 [LLD channel]: Trickplay not functioning correctly when useMp4Demux=true - #1479
Merged
Merged
Conversation
varshnie
force-pushed
the
feature/VPLAY-13151_new
branch
5 times, most recently
from
May 26, 2026 11:12
c71ceca to
408208c
Compare
varshnie
force-pushed
the
feature/VPLAY-13151_new
branch
from
May 26, 2026 12:15
408208c to
d7a1547
Compare
Vinish100
force-pushed
the
feature/VPLAY-13151_new
branch
from
May 26, 2026 18:31
d7a1547 to
0751e96
Compare
varshnie
force-pushed
the
feature/VPLAY-13151_new
branch
5 times, most recently
from
May 27, 2026 16:32
4fdf44d to
46edabc
Compare
DomSyna
reviewed
May 28, 2026
DomSyna
left a comment
DomSyna
left a comment
Contributor
There was a problem hiding this comment.
Mostly trivial comments, though I am concerned there is a potential race condition regarding the trickmode state handling and the APP thread interactions driving setRate() ?
varshnie
force-pushed
the
feature/VPLAY-13151_new
branch
2 times, most recently
from
May 31, 2026 18:53
23bbe0d to
b0103a0
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
DomSyna
approved these changes
Jun 2, 2026
…seMp4Demux=true Reason for change: As the TrickmodeRestamp, is not handled for the Mp4segments, so sudden jumps in the pts value is noticed and the discontinuous segments injected to the pipeline causing trickplay failure. In order to resolve the above issue, handled TrickmodeRestamping accordingly for the Mp4segments Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: lashminthaj <lashminthaj17@gmail.com>
…seMp4Demux=true Reason for change:optimization and sending only the iframe samples to gstreamer handled in localtsb case Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: varshnie <varshniblue14@gmail.com>
…seMp4Demux=true Reason for change:modified trickphase mpode logic from 4 states to 2 states and overrided first pts in case of mp4demux and trickplay mode in getFirstPts Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: varshnie <varshniblue14@gmail.com>
pstroffolino
force-pushed
the
feature/VPLAY-13151_new
branch
from
June 5, 2026 17:16
b0103a0 to
70646de
Compare
shripadbpersonal
pushed a commit
that referenced
this pull request
Jul 20, 2026
…seMp4Demux=true (#1479) * VPLAY-13151 [LLD channel]: Trickplay not functioning correctly when useMp4Demux=true Reason for change: As the TrickmodeRestamp, is not handled for the Mp4segments, so sudden jumps in the pts value is noticed and the discontinuous segments injected to the pipeline causing trickplay failure. In order to resolve the above issue, handled TrickmodeRestamping accordingly for the Mp4segments Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: lashminthaj <lashminthaj17@gmail.com> * VPLAY-13151 [LLD channel]: Trickplay not functioning correctly when useMp4Demux=true Reason for change:optimization and sending only the iframe samples to gstreamer handled in localtsb case Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: varshnie <varshniblue14@gmail.com> * VPLAY-13151 [LLD channel]: Trickplay not functioning correctly when useMp4Demux=true Reason for change:modified trickphase mpode logic from 4 states to 2 states and overrided first pts in case of mp4demux and trickplay mode in getFirstPts Risks: Low Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: varshnie <varshniblue14@gmail.com> --------- Signed-off-by: lashminthaj <lashminthaj17@gmail.com> Signed-off-by: varshnie <varshniblue14@gmail.com> Co-authored-by: lashmintha <lashminthaj17@gmail.com> Co-authored-by: pstroffolino <Philip_Stroffolino@cable.comcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: As the TrickmodeRestamp, is not handled for the Mp4segments, so sudden jumps in the pts value is noticed and the discontinuous segments injected to the pipeline causing trickplay failure. In order to resolve the above issue, handled TrickmodeRestamping accordingly for the Mp4segments
Risks: Low
Test Procedure: Refer jira ticket
Priority: P1