Skip to content

VPAAMP-773: Fix uveExecuter not landing in build/Debug/ on macOS#1729

Merged
pstroffolino merged 5 commits into
dev_sprint_25_2from
feature/VPAAMP-773
Jul 15, 2026
Merged

VPAAMP-773: Fix uveExecuter not landing in build/Debug/ on macOS#1729
pstroffolino merged 5 commits into
dev_sprint_25_2from
feature/VPAAMP-773

Conversation

@pstroffolino

Copy link
Copy Markdown
Contributor

The cmake configure step bakes SYMROOT=XcodeDerivedData into the Xcode project. The previous xcodebuild invocation for uveExecuter inherited that setting, placing the binary in XcodeDerivedData/Debug/ instead of build/Debug/ where aamp-uve.sh expects it.

Fix: pass SYMROOT="$AAMP_DIR/build" explicitly when building uveExecuter so the binary always lands at build/Debug/uveExecuter.

The cmake configure step bakes SYMROOT=XcodeDerivedData into the Xcode
project. The previous xcodebuild invocation for uveExecuter inherited
that setting, placing the binary in XcodeDerivedData/Debug/ instead of
build/Debug/ where aamp-uve.sh expects it.

Fix: pass SYMROOT="$AAMP_DIR/build" explicitly when building uveExecuter
so the binary always lands at build/Debug/uveExecuter.
@pstroffolino
pstroffolino requested a review from a team as a code owner July 14, 2026 14:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the macOS Xcode build output location for the uveExecuter scheme so its binary is produced under build/Debug/ (instead of being redirected under the configured Xcode-derived SYMROOT directory), aligning with downstream tooling expectations.

Changes:

  • Override SYMROOT explicitly when invoking xcodebuild for the uveExecuter scheme on Darwin.
  • Add inline rationale comments explaining why the override is needed (CMake’s configured Xcode SYMROOT redirect).

Comment thread scripts/install_jsbindings.sh Outdated
Comment thread scripts/install_jsbindings.sh Outdated
pstroffolino and others added 2 commits July 14, 2026 15:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@psiva01
psiva01 force-pushed the feature/VPAAMP-773 branch from fc03f2e to b8b6e8c Compare July 15, 2026 09:22
@pstroffolino
pstroffolino merged commit 4358bca into dev_sprint_25_2 Jul 15, 2026
9 checks passed
@pstroffolino
pstroffolino deleted the feature/VPAAMP-773 branch July 15, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants