RDKEMW-14537: Coverity integration for ctrlm#199
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
msmith113
force-pushed
the
feature/RDKEMW-14537
branch
from
61d9bce to
895e258
Compare
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions-native build path intended to support Coverity analysis for the Control Manager (ctrlm) project by provisioning dependencies in CI and running a specialized CMake/Ninja build.
Changes:
- Introduces a dependency bootstrap script that installs packages, clones/builds required Thunder/entservices components, and creates stub headers/libs for external deps.
- Adds a Coverity-oriented build script that configures ctrlm with mocks/stubs and attempts to neutralize
-Werrorfor analysis builds. - Adds a new GitHub Actions workflow to run the above in a containerized Ubuntu environment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
build_dependencies.sh |
Installs deps, clones/builds Thunder + entservices-apis, generates stub headers/libs for native CI buildability. |
cov_build.sh |
Configures and builds ctrlm with CMake/Ninja using mocks/stubs and Coverity-friendly flags. |
.github/workflows/native_full_build.yml |
CI workflow wiring to run dependency + build scripts in a container. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…gin' into feature/RDKEMW-14537
|
b'## Copyright scan failure |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dwolaver
left a comment
dwolaver
left a comment
There was a problem hiding this comment.
Looks good! Mostly some suggestions for future improvements...
| @@ -0,0 +1,40 @@ | |||
| --- a/Tests/mocks/devicesettings.h 2026-04-21 19:12:58.154981897 +0000 | |||
There was a problem hiding this comment.
Should we create a follow up ticket to eliminate this patch?
| @@ -0,0 +1,57 @@ | |||
| /* | |||
There was a problem hiding this comment.
I imagine all of this will be removed in RDKEMW-17087 so it's fine for now.
| * | ||
| * The production rdkx_logger.h is included transitively everywhere via | ||
| * ctrlm_log.h. In the Yocto build the SDK headers pull several std:: names | ||
| * into the global namespace. A handful of ctrlm TUs (e.g. ctrlm_utils.cpp) |
There was a problem hiding this comment.
Seems like we may be better off removing this whole compatibility file by modifying the files that rely on the stuff below to build in CI. This can be done in a follow up ticket too.
| mkdir -p "${HEADERS_DIR}/rdk/iarmmgrs-hal" | ||
| mkdir -p "${XRSDK_HEADERS_DIR}" | ||
|
|
||
| # Copy real xr-voice-sdk headers. |
There was a problem hiding this comment.
This is ok for now. However, I wonder if this would be cleaner if it just called cmake on the xr-voice-sdk repo with a target that just delivers the header files?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
msmith113
dismissed
mhughesacn’s stale review
We no longer need license file updates as we removed all of the offending files
https://ccp.sys.comcast.net/browse/RDKEMW-14537
cifolder which contains build scripts, mocks, patches, and other dependencies needed for a native ci build.Created RDKEMW-18082 to address any unresolved comments/suggestions