-
Notifications
You must be signed in to change notification settings - Fork 4
RDKEMW-14537: Coverity integration for ctrlm #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
414b130
Release/1.1.12 (#200)
egalla204 02e0576
Merge branch 'release/1.1.12'
egalla204 895e258
RDKEMW-14537: Coverity integration for ctrlm
msmith113 f39f025
Removing feature/** from push workflow
msmith113 11c36ce
Updates
msmith113 ae4a2ae
Update cov_build.sh
msmith113 a7950c8
Update cov_build.sh
msmith113 f1c00d9
Update
msmith113 97c049e
Moving mock headers out of test framework
msmith113 68525ce
More testing
msmith113 906513c
Test
msmith113 126b843
Merge branch 'feature/RDKEMW-14537-test', remote-tracking branch 'ori…
msmith113 9d6bded
Adding missing new lines and updating copyright
msmith113 4eabde2
Adding copilot instructions to give more context about the ci dir
msmith113 59274cd
Updates
msmith113 1780b23
Testing changes
msmith113 cb35a13
Slowly removing mock headers for actual ones in xr-audio-sdk
msmith113 ce02dc4
More changes to move away from mock headers
msmith113 1bc2106
Updating credit related text for LICENSE, NOTICE, source, and copyright
msmith113 1dd2743
Using test framework again, but in a way of not modifying it (testing)
msmith113 918cad5
More testing
msmith113 d6d9ab2
CHanges
msmith113 361475c
More updates
msmith113 4776729
Update ci/patches/Use_Legact_Alt_Based_On_ThunderTools_R4.4.3.patch
msmith113 3ab8ebb
Fixing typo in patch sourse
msmith113 17d174d
Using patches from test framework instead of local copies
msmith113 90ad5f1
Test
msmith113 c834690
Updates
msmith113 0c6c05f
Reduce mock attempt
msmith113 148abd3
Test
msmith113 acd5168
Test again
msmith113 bac6a8e
Updates
msmith113 02cb06e
Testing
msmith113 55a312c
Test
msmith113 689fdda
More test
msmith113 57f86af
Testing
msmith113 becfca5
Update
msmith113 b0e1413
Updates
msmith113 3fe154d
Updates
msmith113 cdfd057
Test
msmith113 aac5264
Testing
msmith113 a2bd13b
Testing
msmith113 02d9da3
Apply suggestion from @Copilot
msmith113 69e0be2
Removing rdkversion mock
msmith113 799d667
Update ci/build_dependencies.sh
msmith113 3ec51bc
Update ci/cov_build.sh
msmith113 47a30b6
Update
msmith113 8915c26
Update
msmith113 42bf116
Small tweaks to git commands
msmith113 81392f9
Updating mock comments
msmith113 a4584ba
Clean up
msmith113 1834446
Making changes suggested from copilot
msmith113 11b6589
Updates
msmith113 e551ccd
Updates
msmith113 f13e688
Update ci/cov_build.sh
msmith113 71f0eb5
Update ci/mocks/control/rdkx_logger.h
msmith113 e0b3a17
Test
msmith113 6ffeaaf
Updates
msmith113 8469088
Initial commit of mock reduction
msmith113 10579d0
Updates
msmith113 f159487
Updates
msmith113 34c7fb3
Updates
msmith113 700be5a
Updates
msmith113 1e72897
Fixing patch
msmith113 1cc5e02
Update ci/mocks/testframework_overrides.h
msmith113 f8d1cee
More tests
msmith113 de2a1c8
Merge branch 'feature/RDKEMW-14537' of github-rdkcentral:rdkcentral/c…
msmith113 9cdf6be
Update ci/build_dependencies.sh
msmith113 223c1ee
Update ci/build_dependencies.sh
msmith113 c918033
Update
msmith113 74a0fac
Updating comment of stripping -Werror from generated build
msmith113 4b3a2c5
Update ci/mocks/devicesettings_ctrlm.patch
msmith113 43c2ace
Update ci/build_dependencies.sh
msmith113 112b9f8
Cleanup
msmith113 0644885
Fix issues create by copilot suggestion
msmith113 611eab7
Merge branch 'develop' into feature/RDKEMW-14537
msmith113 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Copilot Instructions | ||
|
|
||
| ## Repository overview | ||
| This is the **ctrlm-main** (Control Manager) plugin — a Thunder/WPEFramework plugin for RDK remote control management. | ||
|
|
||
| ## ci/ directory | ||
| The `ci/` directory contains **native CI build support files only**. It is not part of the application. | ||
|
|
||
| - `ci/build_dependencies.sh` / `ci/cov_build.sh` — scripts that build the plugin in a CI container without a full RDK target image | ||
| - `ci/mocks/xlog_ci_compat.h` — minimal shim that pulls `std::string`, `std::map`, `std::tuple`, `std::get` into the global namespace (mirrors the transitive effect of the real rdkx_logger.h in the Yocto build) | ||
| - `ci/mocks/testframework_overrides.h` — supplements testframework mocks with declarations ctrlm needs that are not yet upstream | ||
| - `ci/mocks/devicesettings_ctrlm.patch` — patch applied to the testframework `devicesettings.h` at CI time for ctrlm-specific additions (ducking types, `setAudioDucking`, `Manager::IsInitialized`). Remove once these land in testframework develop. | ||
| - `ci/mocks/safec_lib.h` — compatibility shim mapping `safec_lib.h` to system libsafec headers | ||
| - `ci/headers/` — empty stub headers and real xr-voice-sdk headers generated/copied at CI build time; not committed to source | ||
|
|
||
| CI currently pins `xr-voice-sdk` to tag `1.0.13` in `build_dependencies.sh`. Real xr-voice-sdk headers (including `rdkx_logger.h`, `xr_voice_sdk.h`, and generated `rdkx_logger_modules.h`) are produced by `build_dependencies.sh` and placed in `ci/headers/xr-voice-sdk/`. Mock/stub headers for platform libraries (IARM, DeviceSettings, RFC, etc.) are sourced from `entservices-testframework/` at CI build time. | ||
|
|
||
| When suggesting code or answering questions, treat CI mocks as scaffolding, not as authoritative API definitions. For real API shapes refer to the installed headers under `install/usr/include/` or the upstream repositories (Thunder, entservices-apis, xr-voice-sdk). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Build Control Manager in Native Environment | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, 'sprint/**', 'release/**', develop ] | ||
| pull_request: | ||
| branches: [ main, 'sprint/**', 'release/**', topic/RDK*, develop ] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build-control-on-pr: | ||
| name: Build Control Manager in github rdkcentral | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/rdkcentral/docker-rdk-ci:latest | ||
|
msmith113 marked this conversation as resolved.
|
||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: build dependencies | ||
| run: | | ||
| sh -x ci/build_dependencies.sh | ||
|
|
||
| - name: cov build | ||
| run: | | ||
| sh -x ci/cov_build.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,204 @@ | ||
| #!/bin/bash | ||
| # | ||
| # If not stated otherwise in this file or this component's license file the | ||
| # following copyright and licenses apply: | ||
| # | ||
| # Copyright 2026 RDK Management | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -x | ||
| set -e | ||
|
msmith113 marked this conversation as resolved.
msmith113 marked this conversation as resolved.
|
||
| ############################## | ||
| GITHUB_WORKSPACE="${PWD}" | ||
| cd "${GITHUB_WORKSPACE}" | ||
|
|
||
| git config --global --add safe.directory "${GITHUB_WORKSPACE}" | ||
|
|
||
| # ############################# | ||
| # 1. Install Dependencies and packages | ||
|
|
||
| apt update | ||
| apt install -y \ | ||
| pkg-config \ | ||
| libsqlite3-dev \ | ||
| libcurl4-openssl-dev \ | ||
| libsystemd-dev \ | ||
| libglib2.0-dev \ | ||
| libjansson-dev \ | ||
| libarchive-dev \ | ||
| libssl-dev \ | ||
| zlib1g-dev \ | ||
| libdbus-1-dev \ | ||
| uuid-dev \ | ||
| libevdev-dev \ | ||
| libdrm-dev \ | ||
| libsafec-dev \ | ||
| python3-pip | ||
| python3 -m pip install jsonref | ||
|
msmith113 marked this conversation as resolved.
|
||
|
|
||
| ########################################### | ||
| # 2. Clone the required repositories | ||
|
|
||
| XRSDK_REF="1.0.13" | ||
| git clone --depth 1 --filter=blob:none --branch "${XRSDK_REF}" https://github.com/rdkcentral/xr-voice-sdk.git | ||
|
|
||
| git clone --depth 1 --filter=blob:none --branch develop https://github.com/rdkcentral/entservices-testframework.git | ||
|
|
||
| # Patch the upstream testframework devicesettings.h with ctrlm-specific | ||
| # additions (ducking types, setAudioDucking, Manager::IsInitialized). | ||
| # We can remove this if added to upstream testframework | ||
| git -C entservices-testframework apply "$GITHUB_WORKSPACE/ci/mocks/devicesettings_ctrlm.patch" | ||
|
|
||
| git clone --depth 1 --filter=blob:none --sparse --branch develop https://github.com/rdkcentral/iarmmgrs.git | ||
| git -C iarmmgrs sparse-checkout set hal | ||
|
|
||
| git clone --depth 1 --filter=blob:none --sparse https://github.com/rdkcentral/rdk-halif-deepsleep_manager.git | ||
| git -C rdk-halif-deepsleep_manager sparse-checkout set include | ||
|
|
||
| git clone --depth 1 --filter=blob:none --sparse https://github.com/rdkcentral/rdk-halif-power_manager.git | ||
| git -C rdk-halif-power_manager sparse-checkout set include | ||
|
|
||
| git clone --depth 1 --filter=blob:none --sparse --branch develop https://github.com/rdkcentral/rdkversion.git | ||
|
msmith113 marked this conversation as resolved.
msmith113 marked this conversation as resolved.
msmith113 marked this conversation as resolved.
|
||
| git -C rdkversion sparse-checkout set src | ||
|
|
||
|
msmith113 marked this conversation as resolved.
|
||
| IARMMGRS_DIR="$GITHUB_WORKSPACE/iarmmgrs" | ||
| DEEPSLEEP_HAL_DIR="$GITHUB_WORKSPACE/rdk-halif-deepsleep_manager" | ||
| POWER_HAL_DIR="$GITHUB_WORKSPACE/rdk-halif-power_manager" | ||
| RDKVERSION_DIR="$GITHUB_WORKSPACE/rdkversion" | ||
|
|
||
| ############################ | ||
| # 3. Create stub/empty headers for external dependencies | ||
| echo "======================================================================================" | ||
| echo "Creating stub headers" | ||
|
|
||
| HEADERS_DIR="$GITHUB_WORKSPACE/ci/headers" | ||
| XRSDK_HEADERS_DIR="$HEADERS_DIR/xr-voice-sdk" | ||
| mkdir -p "${HEADERS_DIR}" | ||
| mkdir -p "${HEADERS_DIR}/rdk/iarmbus" | ||
| mkdir -p "${HEADERS_DIR}/rdk/ds" | ||
| mkdir -p "${HEADERS_DIR}/rdk/iarmmgrs-hal" | ||
| mkdir -p "${XRSDK_HEADERS_DIR}" | ||
|
|
||
| # Copy real xr-voice-sdk headers. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is ok for now. However, I wonder if this would be cleaner if it just called cmake on the xr-voice-sdk repo with a target that just delivers the header files? |
||
| # xr_fdc.h is NOT copied: only needed when FDC_ENABLED=ON | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-speech-vrex/xrsv.h" "${XRSDK_HEADERS_DIR}/" | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-speech-router/xrsr.h" "${XRSDK_HEADERS_DIR}/" | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-mq/xr_mq.h" "${XRSDK_HEADERS_DIR}/" | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-speech-vrex/xrsv_http/xrsv_http.h" "${XRSDK_HEADERS_DIR}/" | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-speech-vrex/xrsv_ws_nextgen/xrsv_ws_nextgen.h" "${XRSDK_HEADERS_DIR}/" | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-timestamp/xr_timestamp.h" "${XRSDK_HEADERS_DIR}/" | ||
|
|
||
| # Generate rdkx_logger_modules.h from xr-voice-sdk's module configuration, | ||
| # then copy the real rdkx_logger and xr_voice_sdk headers. | ||
| # This replaces the hand-written ci/mocks/control/ stubs. | ||
| python3 "$GITHUB_WORKSPACE/xr-voice-sdk/scripts/rdkx_logger_modules_to_c.py" \ | ||
| "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-logger/rdkv/rdkx_logger_modules.json" \ | ||
| "${XRSDK_HEADERS_DIR}/rdkx_logger_modules" "mw" | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr-logger/rdkx_logger_mw.h" "${XRSDK_HEADERS_DIR}/rdkx_logger.h" | ||
| cp "$GITHUB_WORKSPACE/xr-voice-sdk/src/xr_voice_sdk.h" "${XRSDK_HEADERS_DIR}/xr_voice_sdk.h" | ||
|
|
||
| cd "${HEADERS_DIR}" | ||
|
|
||
| # IARM headers (types provided via -include Iarm.h) | ||
| touch rdk/iarmbus/libIARM.h | ||
| touch rdk/iarmbus/libIBus.h | ||
| touch rdk/iarmbus/libIBusDaemon.h | ||
|
|
||
| # IARM manager headers | ||
| # sysMgr.h conflicts with the forced Iarm.h mock, which already provides the | ||
| # needed SYSMgr types. Use a shim here. To remove it later, either stop | ||
| # force-including those overlapping Iarm.h declarations or drop sysMgr.h from | ||
| # ctrlm source. | ||
| cat > rdk/iarmmgrs-hal/sysMgr.h <<'EOF' | ||
| #ifndef CTRLM_CI_SYSMGR_SHIM_H | ||
| #define CTRLM_CI_SYSMGR_SHIM_H | ||
|
|
||
| /* SYSMgr declarations are provided by the forced Iarm.h mock in CI. */ | ||
|
|
||
| #endif | ||
| EOF | ||
| cp "$DEEPSLEEP_HAL_DIR/include/deepSleepMgr.h" rdk/iarmmgrs-hal/deepSleepMgr.h | ||
| cp "$POWER_HAL_DIR/include/plat_power.h" rdk/iarmmgrs-hal/pwrMgr.h | ||
| [ -f rdk/iarmmgrs-hal/sysMgr.h ] | ||
| [ -f rdk/iarmmgrs-hal/deepSleepMgr.h ] | ||
| [ -f rdk/iarmmgrs-hal/pwrMgr.h ] | ||
|
|
||
| # Device settings headers (types provided via force-included devicesettings.h mock) | ||
| touch rdk/ds/audioOutputPort.hpp | ||
| touch rdk/ds/dsDisplay.h | ||
| touch rdk/ds/dsError.h | ||
| touch rdk/ds/dsMgr.h | ||
| touch rdk/ds/dsRpc.h | ||
| touch rdk/ds/dsTypes.h | ||
| touch rdk/ds/dsUtl.h | ||
| touch rdk/ds/exception.hpp | ||
| touch rdk/ds/host.hpp | ||
| touch rdk/ds/manager.hpp | ||
| touch rdk/ds/videoOutputPort.hpp | ||
| touch rdk/ds/videoOutputPortConfig.hpp | ||
| touch rdk/ds/videoOutputPortType.hpp | ||
| touch rdk/ds/videoResolution.hpp | ||
| touch rdk/ds/frontPanelIndicator.hpp | ||
| touch rdk/ds/frontPanelConfig.hpp | ||
|
|
||
| # rfcapi.h (types provided via -include Rfc.h) | ||
| touch rfcapi.h | ||
|
|
||
| # comcastIrKeyCodes.h (unconditionally included by ctrlm_main.cpp) | ||
| find "$IARMMGRS_DIR" -name comcastIrKeyCodes.h -print -quit | xargs -r -I{} cp "{}" comcastIrKeyCodes.h | ||
| [ -f comcastIrKeyCodes.h ] | ||
|
msmith113 marked this conversation as resolved.
|
||
|
|
||
| # rdkversion.h (used by ctrlm_main.cpp) | ||
| cp "$RDKVERSION_DIR/src/rdkversion.h" rdkversion.h | ||
| [ -f rdkversion.h ] | ||
|
|
||
| # secure_wrapper (types provided via empty stub — no v_secure_* calls in core) | ||
| touch secure_wrapper.h | ||
|
|
||
| # safec compatibility header - committed in ci/mocks, copied here so it is | ||
| # resolved on the generated-headers include path. | ||
| cp "$GITHUB_WORKSPACE/ci/mocks/safec_lib.h" safec_lib.h | ||
|
|
||
| echo "Stub headers created successfully" | ||
|
|
||
| cd "${GITHUB_WORKSPACE}" | ||
|
|
||
| mkdir -p "${GITHUB_WORKSPACE}/install/usr/include" | ||
| printf '{}\n' > "${GITHUB_WORKSPACE}/install/usr/include/ctrlm_config_empty.json" | ||
|
|
||
| ############################ | ||
| # 4. Create stub shared libraries for linking | ||
| echo "======================================================================================" | ||
| echo "Creating stub libraries" | ||
|
|
||
| STUB_LIB_DIR="$GITHUB_WORKSPACE/install/usr/lib" | ||
| mkdir -p "${STUB_LIB_DIR}" | ||
|
|
||
| # Create a minimal C stub source | ||
| cat > /tmp/stub.c << 'STUB_EOF' | ||
| void __stub_placeholder(void) {} | ||
| STUB_EOF | ||
|
|
||
| # Build stub .so for each missing library | ||
| # nopoll and dshalcli are unused (factory-only) but unconditionally linked by CMakeLists.txt | ||
| # We can remove them from the link list in the future if desired, but for now just provide stubs to satisfy the linker. | ||
| for lib in xr-voice-sdk rdkversion IARMBus ds nopoll dshalcli rfcapi secure_wrapper evdev; do | ||
| gcc -shared -fPIC -o "${STUB_LIB_DIR}/lib${lib}.so" /tmp/stub.c | ||
|
msmith113 marked this conversation as resolved.
msmith113 marked this conversation as resolved.
|
||
| done | ||
|
|
||
| rm /tmp/stub.c | ||
|
|
||
| echo "Stub libraries created in ${STUB_LIB_DIR}" | ||
| echo "======================================================================================" | ||
| echo "build_dependencies.sh complete" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| #!/bin/bash | ||
| # | ||
| # If not stated otherwise in this file or this component's license file the | ||
| # following copyright and licenses apply: | ||
| # | ||
| # Copyright 2026 RDK Management | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| set -x | ||
| set -e | ||
| ############################## | ||
| GITHUB_WORKSPACE="${PWD}" | ||
| ls -la "${GITHUB_WORKSPACE}" | ||
| ############################ | ||
|
|
||
| # Build control (ctrlm-main) | ||
| echo "building control (ctrlm-main)" | ||
|
|
||
| XRSDK_REAL_HEADERS="$GITHUB_WORKSPACE/ci/headers/xr-voice-sdk" | ||
| XLOG_COMPAT="$GITHUB_WORKSPACE/ci/mocks/xlog_ci_compat.h" | ||
| MOCK_DIR="$GITHUB_WORKSPACE/entservices-testframework/Tests/mocks" | ||
| MOCK_OVERRIDES="$GITHUB_WORKSPACE/ci/mocks/testframework_overrides.h" | ||
| HEADERS_DIR="$GITHUB_WORKSPACE/ci/headers" | ||
| EMPTY_JSON="$GITHUB_WORKSPACE/install/usr/include/ctrlm_config_empty.json" | ||
| GLIB_CFLAGS="$(pkg-config --cflags glib-2.0)" | ||
|
|
||
| cmake -G Ninja -S "$GITHUB_WORKSPACE" -B build/control \ | ||
| -DCMAKE_INSTALL_PREFIX="${GITHUB_WORKSPACE}/install/usr" \ | ||
| -DCMAKE_INSTALL_SYSCONFDIR="${GITHUB_WORKSPACE}/install/etc" \ | ||
| -DCMAKE_MODULE_PATH="${GITHUB_WORKSPACE}/install/tools/cmake" \ | ||
| -DCMAKE_VERBOSE_MAKEFILE=ON \ | ||
|
msmith113 marked this conversation as resolved.
|
||
| -DCMAKE_PROJECT_VERSION="1.0.0" \ | ||
| -DTHUNDER=OFF \ | ||
| -DTHUNDER_SECURITY=OFF \ | ||
| -DBLE_ENABLED=OFF \ | ||
| -DRF4CE_ENABLED=OFF \ | ||
| -DIP_ENABLED=OFF \ | ||
| -DTELEMETRY_SUPPORT=OFF \ | ||
| -DAUTH_ENABLED=OFF \ | ||
| -DXRSR_HTTP=OFF \ | ||
| -DXRSR_SDT=OFF \ | ||
| -DBUILD_CTRLM_FACTORY=OFF \ | ||
| -DBUILD_FACTORY_TEST=OFF \ | ||
| -DUSE_SAFEC=OFF \ | ||
| -DUSE_IARM_POWER_MANAGER=ON \ | ||
| -DBREAKPAD=OFF \ | ||
| -DFDC_ENABLED=OFF \ | ||
| -DENABLE_ASYNC_SRVR_MSG=OFF \ | ||
| -DHIDE_NON_EXTERNAL_SYMBOLS=OFF \ | ||
| -DBUILD_SYSTEM=NONE \ | ||
| -DCTRLM_UTILS_JSON_COMBINE="${GITHUB_WORKSPACE}/xr-voice-sdk/scripts/vsdk_json_combine.py" \ | ||
| -DCTRLM_UTILS_JSON_TO_HEADER="${GITHUB_WORKSPACE}/xr-voice-sdk/scripts/vsdk_json_to_header.py" \ | ||
| -DCTRLM_CONFIG_JSON_CPC="${EMPTY_JSON}" \ | ||
| -DCTRLM_CONFIG_JSON_CPC_SUB="${EMPTY_JSON}" \ | ||
| -DCTRLM_CONFIG_JSON_CPC_ADD="${EMPTY_JSON}" \ | ||
| -DCTRLM_CONFIG_JSON_MAIN_SUB="${EMPTY_JSON}" \ | ||
| -DCTRLM_CONFIG_JSON_MAIN_ADD="${EMPTY_JSON}" \ | ||
| -DCMAKE_CXX_FLAGS=" \ | ||
| -I ${XRSDK_REAL_HEADERS} \ | ||
| -I ${MOCK_DIR} \ | ||
| -I ${MOCK_DIR}/devicesettings \ | ||
| -I ${HEADERS_DIR} \ | ||
| -I ${HEADERS_DIR}/rdk/iarmbus \ | ||
| -I ${HEADERS_DIR}/rdk/ds \ | ||
| -I ${HEADERS_DIR}/rdk/iarmmgrs-hal \ | ||
| -I ${GITHUB_WORKSPACE}/install/usr/include \ | ||
| -I /usr/include/libdrm \ | ||
| ${GLIB_CFLAGS} \ | ||
| -include ${XLOG_COMPAT} \ | ||
| -include ${MOCK_DIR}/Iarm.h \ | ||
| -include ${MOCK_OVERRIDES} \ | ||
| -include ${MOCK_DIR}/devicesettings.h \ | ||
| -include ${MOCK_DIR}/Rfc.h \ | ||
| -Wall -Wno-error \ | ||
| -DSAFEC_DUMMY_API \ | ||
| -DDISABLE_SECURITY_TOKEN" \ | ||
| -DCMAKE_C_FLAGS=" \ | ||
| -I ${XRSDK_REAL_HEADERS} \ | ||
| -I ${MOCK_DIR} \ | ||
| -I ${HEADERS_DIR} \ | ||
| -I ${HEADERS_DIR}/rdk/iarmbus \ | ||
| -I ${HEADERS_DIR}/rdk/ds \ | ||
| -I ${HEADERS_DIR}/rdk/iarmmgrs-hal \ | ||
| -I ${GITHUB_WORKSPACE}/install/usr/include \ | ||
| -I /usr/include/libdrm \ | ||
| ${GLIB_CFLAGS} \ | ||
| -Wall -Wno-error \ | ||
| -DSAFEC_DUMMY_API \ | ||
| -DDISABLE_SECURITY_TOKEN" \ | ||
| -DCMAKE_EXE_LINKER_FLAGS="-L${GITHUB_WORKSPACE}/install/usr/lib -Wl,--unresolved-symbols=ignore-all" | ||
|
msmith113 marked this conversation as resolved.
|
||
|
|
||
| # CMakeLists.txt unconditionally appends -Werror via target_compile_options, which | ||
| # comes after CMAKE_CXX_FLAGS and overrides -Wno-error. Strip it from the generated | ||
| # build files after cmake configure. To remove this, add an ENABLE_WERROR option to | ||
| # CMakeLists.txt that appends -Wno-error when OFF, and pass -DENABLE_WERROR=OFF here. | ||
| find "${GITHUB_WORKSPACE}/build/control" \( -name "*.ninja" -o -name "flags.make" \) -exec sed -i 's/\(^\|[[:space:]]\)-Werror\([[:space:]]\|$\)/\1\2/g' {} \; | ||
|
|
||
| cmake --build build/control -j$(nproc) 2>&1 | ||
|
msmith113 marked this conversation as resolved.
|
||
| echo "======================================================================================" | ||
| echo "control build complete" | ||
| exit 0 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.