RDKEMW-17935 : remove ctrlm build flags - USE_DEPRECATED_HDMI_INPUT_P… - #250
Merged
dwolaver merged 2 commits intoJul 8, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated HDMIInput Thunder plugin integration and its associated build flag, standardizing the TV platform path to use the AVInput Thunder plugin.
Changes:
- Deleted the deprecated
ctrlm_thunder_plugin_hdmi_inputimplementation (header + source). - Removed the
USE_DEPRECATED_HDMI_INPUT_PLUGINCMake option/compile definition and all conditional compilation using it. - Updated IRDB Thunder hookup to always use
Thunder::AVInput::ctrlm_thunder_plugin_av_input_t.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/thunder/plugins/ctrlm_thunder_plugin_hdmi_input.h |
Removed deprecated HDMIInput plugin wrapper header. |
src/thunder/plugins/ctrlm_thunder_plugin_hdmi_input.cpp |
Removed deprecated HDMIInput plugin wrapper implementation. |
src/irdb/ctrlm_irdb_interface.cpp |
Dropped conditional HDMIInput/AVInput selection; always uses AVInput on TV platforms. |
src/CMakeLists.txt |
Removed deprecated HDMIInput plugin source from the Thunder build sources list. |
CMakeLists.txt |
Removed the USE_DEPRECATED_HDMI_INPUT_PLUGIN option and its compile definition wiring. |
…ECATED_HDMI_INPUT_PLUGIN
egalla204
approved these changes
Jul 8, 2026
dwolaver
deleted the
feature/RDKEMW-17935_remove_flag_USE_DEPRECATED_HDMI_INPUT_PLUGIN
branch
July 8, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…LUGIN