Skip to content

RDKEMW-4056 : RFC overrides for BLE network config#52

Merged
dwolaver merged 8 commits into
developfrom
feature/RDKEMW-4056_ble_network_config_update_via_rfc
Jul 16, 2026
Merged

RDKEMW-4056 : RFC overrides for BLE network config#52
dwolaver merged 8 commits into
developfrom
feature/RDKEMW-4056_ble_network_config_update_via_rfc

Conversation

@dwolaver

Copy link
Copy Markdown
Contributor

RFC overrides for BLE network config

@dwolaver
dwolaver requested review from a team May 13, 2025 16:52
@dwolaver
dwolaver requested a review from a team as a code owner July 7, 2026 17:38
Copilot AI review requested due to automatic review settings July 7, 2026 17:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds RFC handling in the BLE network layer intended to override BLE pairing-related timeout configuration at runtime.

Changes:

  • Implemented parsing of RFC integer values for BLE timeouts (discovery/pair/setup/unpair).
  • Added logging for the retrieved timeout values (with placeholders for applying them).

Comment thread src/ble/ctrlm_ble_network.cpp Outdated
Comment thread src/ble/ctrlm_ble_network.cpp Outdated
@dwolaver
dwolaver marked this pull request as draft July 7, 2026 17:48
@dwolaver
dwolaver marked this pull request as ready for review July 8, 2026 01:10
Copilot AI review requested due to automatic review settings July 8, 2026 01:10
@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/control/52/rdk/components/generic/control

  • Commit: 6b65ced

Report detail: gist'

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread src/ble/ctrlm_ble_network.cpp Outdated
Comment thread src/ble/hal/configsettings/configsettings.cpp
@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: ok

  • Commit: 6b65ced
    '

Copilot AI review requested due to automatic review settings July 8, 2026 14:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread src/ble/hal/configsettings/configsettings.cpp
Comment thread src/ble/hal/blercu/blercupairingstatemachine.cpp
Copilot AI review requested due to automatic review settings July 8, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread src/ble/hal/blercu/blercupairingstatemachine.cpp
Copilot AI review requested due to automatic review settings July 8, 2026 15:30
Comment thread src/ble/hal/blercu/blercupairingstatemachine.cpp

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread src/ble/ctrlm_ble_network.cpp
Comment thread src/ble/hal/configsettings/configsettings.cpp

@egalla204 egalla204 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for test

Copilot AI review requested due to automatic review settings July 16, 2026 16:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread src/ble/hal/blercu/blercupairingstatemachine.cpp
@dwolaver
dwolaver merged commit 1fdb0b1 into develop Jul 16, 2026
10 of 11 checks passed
@dwolaver
dwolaver deleted the feature/RDKEMW-4056_ble_network_config_update_via_rfc branch July 16, 2026 17:07
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants