Skip to content

docs: Update uploadSTBLogs design docs to reflect SHA256 archive integrity logging - #112

Merged
shibu-kv merged 2 commits into
feature/sha_valuefrom
copilot/sub-pr-111
Apr 15, 2026
Merged

docs: Update uploadSTBLogs design docs to reflect SHA256 archive integrity logging#112
shibu-kv merged 2 commits into
feature/sha_valuefrom
copilot/sub-pr-111

Conversation

Copilot AI commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

The SHA256 archive integrity logging feature (added to the Direct upload path) was not reflected in any design or requirements documentation.

Changes

  • Requirements (uploadSTBLogs_requirements.md)

    • Promotes OpenSSL EVP from optional to required dependency (SHA256)
    • Updates CPU constraint: SHA256 once per Direct upload; MD5 only when encryption flag set
    • Adds observability requirement: log SHA256 at INFO level before each Direct upload
  • HLD (uploadSTBLogs_HLD.md)

    • Inserts SHA256 calculation as step 2 of Upload Execution Steps (Direct path only)
    • Adds section 8a "Archive Integrity (Direct Path)" describing purpose and approach
  • LLD (uploadSTBLogs_LLD.md)

    • Adds calculate_file_sha256 to functional partitioning table
    • Adds section 7a with full function signature, implementation notes (EVP pipeline, ferror check after read loop, nibble-lookup hex encoding, output_size ≥ 65 guard), and inline code showing call site in execute_direct_path()
  • Flowchart (uploadSTBLogs_flowcharts.md)

    • Adds "Calculate & Log SHA256 (Direct Path Only)" node between pre-sign success and S3 PUT in the fallback sub-flow diagram
  • Sequence diagram (uploadSTBLogs_sequence.md)

    • Adds HashUtil participant and SHA256 calculation/log steps to the Normal Path sequence

Copilot AI changed the title [WIP] [RDKEMW-14842] Logupload sha value to be printed in dcmscript.log docs: Update uploadSTBLogs design docs to reflect SHA256 archive integrity logging Apr 14, 2026
Copilot AI requested a review from shibu-kv April 14, 2026 20:42
@shibu-kv
shibu-kv marked this pull request as ready for review April 15, 2026 18:37
@shibu-kv
shibu-kv requested a review from a team as a code owner April 15, 2026 18:37
Copilot AI review requested due to automatic review settings April 15, 2026 18:37
@shibu-kv
shibu-kv merged commit 5930f38 into feature/sha_value Apr 15, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants