RDKEMW-17026 : Remove OEM/SOC references from the module - #113
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates usbLogUpload documentation/comments to reflect that USB log upload is supported on TV devices (replacing prior PLATCO references).
Changes:
- Replace PLATCO → TV wording in validation comments and public header docs.
- Update requirements/flowchart docs to show device check as “TV”.
- Update README to state TV-only support.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| usbLogUpload/src/usb_log_validation.c | Comment updated to state TV is the supported device. |
| usbLogUpload/include/usb_log_validation.h | API comment updated to TV-only support (but return-code contract text still conflicts with implementation). |
| usbLogUpload/docs/usb-log-upload-requirements.md | Requirements updated to TV-only support (but inputs section still references DEVICE_NAME). |
| usbLogUpload/docs/usb-log-upload-flowcharts.md | Flowcharts updated to show device check as “TV”. |
| usbLogUpload/docs/shared-functions-analysis.md | Notes updated to TV-only requirement. |
| usbLogUpload/README.md | README updated to TV-only support (but device config source/key appears inconsistent with code). |
Abhinavpv28
changed the title
nhanasi
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove OEM/SOC references from the module
Test Procedure: NA
Risks: Low
Signed-off-by: Abhinav P V Abhinav_Valappil@comcast.com