Skip to content

RDK-61009 : [RDKE] Port Log Backup Scripts to Source code - #95

Merged
shibu-kv merged 14 commits into
developfrom
feature/HLD_backuplogs
Mar 12, 2026
Merged

RDK-61009 : [RDKE] Port Log Backup Scripts to Source code#95
shibu-kv merged 14 commits into
developfrom
feature/HLD_backuplogs

Conversation

@Abhinavpv28

@Abhinavpv28 Abhinavpv28 commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Reason for change: Prepare HLD for backupLog script migration
Test Procedure: NA
Risks: Low
Signed-off-by: Abhinav P V Abhinav_Valappil@comcast.com

@Abhinavpv28
Abhinavpv28 requested a review from a team as a code owner March 11, 2026 15:24
Copilot AI review requested due to automatic review settings March 11, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds design/requirements documentation to support migrating the existing backup_logs.sh script into a C implementation for embedded RDK environments, including process diagrams and module/interface descriptions.

Changes:

  • Added functional requirements document for the migration (REQ/NFR, dependencies, acceptance criteria).
  • Added High-Level Design (HLD) describing architecture, modules, and data flow.
  • Added Low-Level Design (LLD) with detailed structures, interfaces, and algorithm sketches, plus flowcharts/diagrams.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File Description
backup_logs/docs/diagrams/backup_logs_flowcharts.md Adds text + Mermaid flow/sequence diagrams for backup paths and error handling.
backup_logs/docs/backup_logs_requirements.md Defines functional/non-functional requirements, I/O, dependencies, and acceptance criteria.
backup_logs/docs/backup_logs_migration_HLD.md Documents architecture/modules, data flow, interfaces, and key algorithms at a high level.
backup_logs/docs/backup_logs_LLD.md Provides detailed structures/interfaces and example algorithms intended to align with implementation.

Comment thread backup_logs/docs/backup_logs_migration_HLD.md Outdated
Comment thread backup_logs/docs/backup_logs_migration_HLD.md Outdated
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md Outdated
Comment thread backup_logs/docs/backup_logs_LLD.md Outdated
Comment thread backup_logs/docs/backup_logs_LLD.md Outdated
Comment thread backup_logs/docs/backup_logs_LLD.md Outdated
Comment thread backup_logs/docs/backup_logs_requirements.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 15:33
Abhinavpv28 and others added 7 commits March 11, 2026 21:04
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.

Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_requirements.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/diagrams/backup_logs_flowcharts.md Outdated
Comment thread backup_logs/docs/backup_logs_requirements.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_migration_HLD.md
Copilot AI review requested due to automatic review settings March 11, 2026 16:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

Comment thread backup_logs/docs/diagrams/backup_logs_flowcharts.md Outdated
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_requirements.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/diagrams/backup_logs_flowcharts.md
Comment thread backup_logs/docs/backup_logs_migration_HLD.md
Comment thread backup_logs/docs/backup_logs_migration_HLD.md
Comment thread backup_logs/docs/backup_logs_migration_HLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 17:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Comment thread backup_logs/docs/backup_logs_requirements.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
Comment thread backup_logs/docs/backup_logs_LLD.md
@shibu-kv
shibu-kv merged commit 54c45f9 into develop Mar 12, 2026
17 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants