RDKB-64256 fix OOB access in log_syntax_error for malformed include parsing - #26
Merged
Conversation
…arsing Guard against null pointers in log_syntax_error. Avoid reading/writing at end by using bounded line scanning. Replace temporary in-place buffer mutation with length-limited logging (%.*s). Prevent potential SIGSEGV/SIGABRT when malformed include syntax reaches EOF.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens malformed include(...) parsing error handling in the JST parser to avoid out-of-bounds access and crashes when the parser reaches EOF or encounters invalid syntax.
Changes:
- Adds null-pointer guarding in
log_syntax_error. - Reworks line scanning to be bounded by
end(avoiding reads/writes at EOF). - Switches logging from in-place buffer mutation to precision-limited
%.*sprinting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snayak002c
approved these changes
Jul 8, 2026
GoutamD2905
approved these changes
Jul 14, 2026
GoutamD2905
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard against null pointers in log_syntax_error.
Avoid reading/writing at end by using bounded line scanning.
Replace temporary in-place buffer mutation with length-limited logging (%.*s).
Prevent potential SIGSEGV/SIGABRT when malformed include syntax reaches EOF.