Skip to content

RDKEMW-17573: Triggering a issue type with more than 35 chars in RRD is leading RDM crash#211

Merged
nhanasi merged 7 commits into
developfrom
feature/property
Jun 10, 2026
Merged

RDKEMW-17573: Triggering a issue type with more than 35 chars in RRD is leading RDM crash#211
nhanasi merged 7 commits into
developfrom
feature/property

Conversation

@Abhinavpv28

@Abhinavpv28 Abhinavpv28 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Reason For change : Loading upload config fails due to empty /opt/dcm.properties file

Copilot AI review requested due to automatic review settings June 8, 2026 10:14
@Abhinavpv28
Abhinavpv28 requested a review from a team as a code owner June 8, 2026 10:14
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Code Coverage Summary

                               Total:|84.1%   6266|97.3%  1669|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates rrd_config_load()’s dcm.properties fallback selection logic by introducing a helper that checks for non-empty files and adjusting which config paths are considered during fallback.

Changes:

  • Added file_non_empty() to detect existing config files with non-zero size.
  • Switched /opt/dcm.properties selection to require a non-empty file during fallback.
  • Modified /etc/dcm.properties fallback selection logic based on BUILD_TYPE.

Comment thread src/rrd_config.c Outdated
Comment thread src/rrd_config.c Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 8, 2026 10:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread src/rrd_config.c Outdated
Copilot AI review requested due to automatic review settings June 8, 2026 10:52
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Code Coverage Summary

                               Total:|84.1%   6266|97.3%  1669|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread src/rrd_config.c Outdated
Comment thread src/rrd_config.c Outdated
Copilot AI review requested due to automatic review settings June 8, 2026 10:56
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Code Coverage Summary

                               Total:|84.1%   6263|97.3%  1668|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread src/rrd_config.c
Copilot AI review requested due to automatic review settings June 8, 2026 10:58
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Code Coverage Summary

                               Total:|84.1%   6263|97.3%  1668|    -      0

1 similar comment
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Code Coverage Summary

                               Total:|84.1%   6263|97.3%  1668|    -      0

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread src/rrd_config.c
@Abhinavpv28 Abhinavpv28 changed the title Update rrd_config.c RRD upload url Being Empty due to empty /opt/dcm.properties Jun 9, 2026
@Abhinavpv28 Abhinavpv28 changed the title RRD upload url Being Empty due to empty /opt/dcm.properties RDKEMW-17573: Triggering a issue type with more than 35 chars in RRD is leading RDM crash Jun 10, 2026
@github-actions

Copy link
Copy Markdown

Code Coverage Summary

                               Total:|84.1%   6263|97.3%  1668|    -      0

@nhanasi
nhanasi merged commit f6a2686 into develop Jun 10, 2026
14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants