RDKEMW-17573: Triggering a issue type with more than 35 chars in RRD is leading RDM crash#211
Merged
Conversation
Code Coverage Summary |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates rrd_config_load()’s dcm.properties fallback selection logic by introducing a helper that checks for non-empty files and adjusting which config paths are considered during fallback.
Changes:
- Added
file_non_empty()to detect existing config files with non-zero size. - Switched
/opt/dcm.propertiesselection to require a non-empty file during fallback. - Modified
/etc/dcm.propertiesfallback selection logic based onBUILD_TYPE.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Code Coverage Summary |
Code Coverage Summary |
Code Coverage Summary |
1 similar comment
Code Coverage Summary |
nhanasi
approved these changes
Jun 9, 2026
Code Coverage Summary |
nhanasi
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason For change : Loading upload config fails due to empty /opt/dcm.properties file