Skip to content

RDKB-63483: RFC Fix L1 Issues with new logger api#175

Merged
nhanasi merged 15 commits intodevelopfrom
feature/rfclog
Feb 16, 2026
Merged

RDKB-63483: RFC Fix L1 Issues with new logger api#175
nhanasi merged 15 commits intodevelopfrom
feature/rfclog

Conversation

@nhanasi
Copy link
Contributor

@nhanasi nhanasi commented Feb 12, 2026

No description provided.

@nhanasi nhanasi requested a review from a team as a code owner February 12, 2026 19:53
Copilot AI review requested due to automatic review settings February 12, 2026 19:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a new logging abstraction layer to handle RDK logger functionality with graceful fallbacks. The changes create a unified header (rdk_debug.h) that provides RDK logger definitions and macros, replacing direct conditional includes of rdk_logger.h throughout the codebase.

Changes:

  • Created rfcMgr/rdk_debug.h to provide RDK logger abstractions with fallback implementations when the real logger is unavailable
  • Removed conditional #include "rdk_logger.h" from rfcMgr/rfc_manager.cpp as the logger is now accessed through rfc_common.h

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
rfcMgr/rdk_debug.h New header file providing RDK logger definitions, fallback implementations, and compatibility layer for different build configurations
rfcMgr/rfc_manager.cpp Removed direct conditional include of rdk_logger.h (now accessed via rfc_common.h which includes rdk_debug.h)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Feb 12, 2026

@nhanasi I've opened a new pull request, #176, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Feb 12, 2026

@nhanasi I've opened a new pull request, #177, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI and others added 4 commits February 12, 2026 20:15
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Add missing RDK_LOG_FATAL constant to fallback definitions
@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (nhanasi)[https://github.com/nhanasi]
❌ @Copilot
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 12, 2026 20:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nhanasi nhanasi changed the title Feature/rfclog RDKB-63412: RFC Fix L1 Issues with new logger api Feb 12, 2026
AravindanNC
AravindanNC previously approved these changes Feb 12, 2026
Copilot AI review requested due to automatic review settings February 12, 2026 21:38
@nhanasi nhanasi changed the title RDKB-63412: RFC Fix L1 Issues with new logger api RDKB-63483: RFC Fix L1 Issues with new logger api Feb 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 13, 2026 21:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nhanasi nhanasi merged commit f329d0a into develop Feb 16, 2026
16 of 19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants