RDKB-63483: RFC Fix L1 Issues with new logger api#175
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new logging abstraction layer to handle RDK logger functionality with graceful fallbacks. The changes create a unified header (rdk_debug.h) that provides RDK logger definitions and macros, replacing direct conditional includes of rdk_logger.h throughout the codebase.
Changes:
- Created
rfcMgr/rdk_debug.hto provide RDK logger abstractions with fallback implementations when the real logger is unavailable - Removed conditional
#include "rdk_logger.h"fromrfcMgr/rfc_manager.cppas the logger is now accessed throughrfc_common.h
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| rfcMgr/rdk_debug.h | New header file providing RDK logger definitions, fallback implementations, and compatibility layer for different build configurations |
| rfcMgr/rfc_manager.cpp | Removed direct conditional include of rdk_logger.h (now accessed via rfc_common.h which includes rdk_debug.h) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Add missing RDK_LOG_FATAL constant to fallback definitions
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.