Skip to content

Add missing RDK_LOG_FATAL constant to fallback definitions#177

Merged
nhanasi merged 4 commits intofeature/rfclogfrom
copilot/sub-pr-175-again
Feb 12, 2026
Merged

Add missing RDK_LOG_FATAL constant to fallback definitions#177
nhanasi merged 4 commits intofeature/rfclogfrom
copilot/sub-pr-175-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

The RDK_LOG_FATAL constant was referenced in rdkv_cdl_log_wrapper.h:34 but undefined in the fallback definitions when the real RDK logger is unavailable.

Changes:

  • Added RDK_LOG_FATAL (value 6) to both fallback constant sets in rdk_debug.h
  • Extended the fallback RDK_LOG macro to handle RDK_LOG_FATAL with "FATAL:" prefix
  • Added .gitignore for autotools build artifacts

Context:

// rdkv_cdl_log_wrapper.h uses RDK_LOG_FATAL
#define SWLOG_FATAL(format, ...) RDK_LOG(RDK_LOG_FATAL, "LOG.RDK.FWUPG", format"\n", ##__VA_ARGS__)

// Now defined in fallback when rdk_logger.h is unavailable
#define RDK_LOG_FATAL 6  // After RDK_LOG_ERROR (5)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI and others added 3 commits February 12, 2026 20:15
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>
@nhanasi nhanasi marked this pull request as ready for review February 12, 2026 20:17
Copilot AI changed the title [WIP] WIP to address feedback on feature/rfclog Add missing RDK_LOG_FATAL constant to fallback definitions Feb 12, 2026
@nhanasi nhanasi requested a review from a team as a code owner February 12, 2026 20:17
Copilot AI review requested due to automatic review settings February 12, 2026 20:17
Copilot AI requested a review from nhanasi February 12, 2026 20:18
@nhanasi nhanasi merged commit faa6b7b into feature/rfclog Feb 12, 2026
3 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants