Get the pipeline position instead of video sink position when syncing the subtitles#559
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
Pull request overview
This PR fixes subtitle synchronization by using the pipeline position (via IGstGenericPlayerPrivate::getPosition) instead of querying the video sink position when emitting the current-pts event to the subtitle source.
Changes:
- Query playback position from the pipeline (
m_context.pipeline) rather thanm_context.videoSink. - Early-return when position retrieval fails (instead of continuing with a default/previous value).
- Keep sending a
current-ptscustom downstream OOB event to the subtitle appsrc for sync.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage statistics of your commit: |
Summary: Get the pipeline position instead of video sink position when syncing the subtitles
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-21216