Merged
Conversation
…sl version (#291) * RDKB-63722: Update multicurlinterface.c * RDKB-63722: Build fix * RDKB-63722: Build fix * astyle formatter error changes are addressed --------- Co-authored-by: tabbas651 <thamimrazith_abbasali@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the 1.8.3 release by fixing OpenSSL-thread cleanup calls to build on platforms with older OpenSSL versions and updating the changelog accordingly.
Changes:
- Add OpenSSL version gating for per-thread cleanup (
OPENSSL_thread_stop()vsERR_remove_thread_state(NULL)). - Include
<openssl/crypto.h>to ensure required OpenSSL APIs are declared. - Add a
1.8.3entry toCHANGELOG.md(and add the1.8.2release date line).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/protocol/http/multicurlinterface.c | Makes OpenSSL per-thread cleanup compile across OpenSSL versions by switching APIs based on OPENSSL_VERSION_NUMBER. |
| CHANGELOG.md | Adds release notes for 1.8.3 and updates 1.8.2 metadata. |
You can also share your feedback on Copilot code review. Take the survey.
| Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | ||
|
|
||
| #### [1.8.3](https://github.com/rdkcentral/telemetry/compare/1.8.2...1.8.3) | ||
|
|
|
|
||
| #### [1.8.3](https://github.com/rdkcentral/telemetry/compare/1.8.2...1.8.3) | ||
|
|
||
| - RDKB-63722: Build fix for ssl crypto error in platforms with lower ssl version [`#291`](https://github.com/rdkcentral/telemetry/pull/291) |
Code Coverage Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.