Conversation
…int image in WANOE. Reason for the change: https://github.com/rdkcentral/wan-manager/pull/172/files - Causing this issue. So wanted to correct this behavior. Signed-off-by: LakshminarayananShenbagaraj <lakshminarayanan.shenbagaraj2@sky.uk>
Copilot started reviewing on behalf of
LakshminarayananShenbagaraj
December 8, 2025 16:22
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a WAN-down issue in WANOE (WAN over Ethernet) configurations caused by a previous change (PR #172). The fix addresses a race condition where the parallel scan policy could start a new interface state machine on an interface that was still in the process of shutting down, leading to incorrect WAN status.
- Added a check for
Interface_SM_Runningflag in the parallel scan policy to prevent starting state machines on interfaces that are still active - Reordered
Update_Interface_Status()call to execute before clearing DHCP data in the WAN deconfigured transition state
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/WanManager/wanmgr_policy_parallel_scan_impl.c | Added Interface_SM_Running check to scanning interface condition to prevent race conditions when selecting new interfaces |
| source/WanManager/wanmgr_interface_sm.c | Moved Update_Interface_Status() call before WanManager_ClearDHCPData() to ensure status is updated while interface data is still valid |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
S-Parthiban-Selvaraj
approved these changes
Dec 8, 2025
guto86
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR fixes a WAN-down issue in WANOE (WAN over Ethernet) configurations caused by a previous change (PR #172). The fix addresses a race condition where the parallel scan policy could start a new interface state machine on an interface that was still in the process of shutting down, leading to incorrect WAN status.
Interface_SM_Runningflag in the parallel scan policy to prevent starting state machines on interfaces that are still activeUpdate_Interface_Status()call to execute before clearing DHCP data in the WAN deconfigured transition stateReviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.