Allow wedged double and aromatic bonds - #7495
Merged
greglandrum merged 3 commits intoJun 7, 2024
Merged
Conversation
This is a first pass and the testing isn't really there.
switch to not using freetype for the tests
bp-kelley
reviewed
Jun 6, 2024
| int at2Idx = bond->getEndAtomIdx(); | ||
| adjustBondEndsForLabels(at1Idx, at2Idx, end1, end2); | ||
|
|
||
| bool skipFirstLine = false; |
Contributor
There was a problem hiding this comment.
Would "skipOuterLine" be more descriptive if I'm understanding this correctly?
bp-kelley
approved these changes
Jun 6, 2024
bp-kelley
left a comment
bp-kelley
left a comment
Contributor
There was a problem hiding this comment.
Such a simple change to the rendering, nice!
e-kwsm
pushed a commit
to e-kwsm/rdkit
that referenced
this pull request
Jun 30, 2024
* support wedging in double and aromatic bonds This is a first pass and the testing isn't really there. * add expected test results (from windows...) switch to not using freetype for the tests * response to review
greglandrum
added a commit
that referenced
this pull request
Jul 1, 2024
* support wedging in double and aromatic bonds This is a first pass and the testing isn't really there. * add expected test results (from windows...) switch to not using freetype for the tests * response to review
yishutu
pushed a commit
to yishutu/rdkit
that referenced
this pull request
Aug 15, 2024
* support wedging in double and aromatic bonds This is a first pass and the testing isn't really there. * add expected test results (from windows...) switch to not using freetype for the tests * response to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with atropisomers, it's more or less inevitable that we're going to have things like this happen and we need to be able to render them.
This uses the following drawing style for these cases (shown here for aromatic bonds):
(yes, the example molecule is a stupid one... the idea is just to show what the drawing style is)