Skip to content

fix(button): disable brightness styling when disabled - #137

Merged
rdlabo merged 2 commits into
mainfrom
fix/disabled-button-brightness
Sep 2, 2026
Merged

fix(button): disable brightness styling when disabled#137
rdlabo merged 2 commits into
mainfrom
fix/disabled-button-brightness

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • apply --ion-color-*-brightness only to enabled solid submit buttons
  • preserve Ionic's standard contrast color for disabled buttons
  • add an enabled/disabled primary submit-button comparison to the component demo

Testing

  • npm run build
  • cd demo && npm test -- --configuration=ci
  • cd demo && npm run lint
  • cd demo && npm run build -- --configuration=production

Button screenshots are intentionally left to CI.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

failed  2 failed
passed  88 passed

Details

stats  90 tests across 2 suites
duration  2 minutes, 9 seconds
commit  6cea43c
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

Failed tests

chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for button
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for button

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-137/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 1, 2026
@rdlabo

rdlabo commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

@rdlabo
rdlabo merged commit 8701a4e into main Sep 2, 2026
3 checks passed
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit 8701a4e31f90. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios26@9.1.0-beta.pr137.sha8701a4e31f90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant