Skip to content

fix(toolbar): scope spacing to toolbars - #138

Merged
rdlabo merged 3 commits into
mainfrom
fix/toolbar-spacing-scope
Sep 2, 2026
Merged

fix(toolbar): scope spacing to toolbars#138
rdlabo merged 3 commits into
mainfrom
fix/toolbar-spacing-scope

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • scope toolbar button spacing directly to enabled iOS toolbars
  • preserve the iOS mode guard when applying theme margins
  • reset nested back-button margins for the normal ion-buttons structure

Verification

  • npx prettier --check src/styles/components/ion-toolbar.scss
  • npm run build
  • npm run lint (blocked by the existing generated demo/playwright-report/index.html formatting issue)

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  90 passed

Details

stats  90 tests across 2 suites
duration  1 minute, 52 seconds
commit  d91f676
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-138/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-138/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 2, 2026
@rdlabo

rdlabo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

❌ Failed to update screenshots.

Please check the workflow run for details.

@rdlabo

rdlabo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

@rdlabo
rdlabo merged commit 86c0630 into main Sep 2, 2026
9 checks passed
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios26/pr-138/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit 86c06305408b. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios26@9.1.0-beta.pr138.sha86c06305408b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant