Skip to content

Feature/67 paragraphs#87

Merged
hechth merged 34 commits into
mainfrom
feature/67-paragraphs
Feb 6, 2026
Merged

Feature/67 paragraphs#87
hechth merged 34 commits into
mainfrom
feature/67-paragraphs

Conversation

@rdurnik

@rdurnik rdurnik commented Jan 23, 2026

Copy link
Copy Markdown
Owner

No description provided.

@rdurnik
rdurnik requested a review from hechth January 23, 2026 13:50
@rdurnik rdurnik linked an issue Jan 23, 2026 that may be closed by this pull request
@rdurnik

rdurnik commented Jan 26, 2026

Copy link
Copy Markdown
Owner Author

@hechth Not sure why the tests are taking so long for macos. But we were dicussing before that we might remove tests for macos and windows?

@hechth

hechth commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

@rdurnik yeah the long runtimes on macos seem very odd. No idea what is happening here.

I think we should move the Spacy Models to its own class to provide these and use all the interfaces to just receive the models.
You can have a look at this design pattern on how to implement this, as this fits exactly our use case: https://refactoring.guru/design-patterns/singleton

@sonarqubecloud

sonarqubecloud Bot commented Feb 5, 2026

Copy link
Copy Markdown

@hechth
hechth merged commit 8ee6682 into main Feb 6, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve paragraph structure when parsing PDFs

2 participants