lastPageTitle not working, taking value of firsPageTitle

[shhdharmen]

• Description: When we give blank space values to both pagination optios: firstPageText and lastPageText. lastPageTitle takes same value as firstPageTitle.

• Example code or repo: https://stackblitz.com/edit/react-v85cxp?file=Hello.js

• Steps to reproduce: Set firstPageText and lastPageText as blank space, lastPageTitle will take same value of firstPageTitle

• react-bootstrap-table2 version: 3.1.3

[shhdharmen]

Maybe I have found the reason behind this issue, but not sure how to fix:

react-bootstrap-table2/packages/react-bootstrap-table2-paginator/src/page-resolver.js

Lines 141 to 145 in 60eb47d

	} else if (page === firstPageText) {
	title = this.props.firstPageTitle;
	} else if (page === lastPageText) {
	title = this.props.lastPageTitle;
	} else {

So, in above code, for both firstPageText and lastPageText, with blank space as value, it will match conditon of L141 and it will show firstPageTitle.

[AllenFang]

hmm.. yeah this is an edge case but can I know why you set the blank text for both of first & last page button?

[shhdharmen]

I am trying to set a background image for both through css and don't want any content in it. Anyways, it worked when gave: <span /> instead of blank space. I am closing it.

[AllenFang]

👍

[shhdharmen]

Sorry, but if we use jsx element instead of string, it gives compile time errors.

Warning: Failed prop type: Invalid prop `firstPageText` of type `object` supplied to `Pagination`, expected `string`.
in Pagination (created by PaginationHandler)
in PaginationHandler (created by PaginationDataProvider)
in PaginationDataProvider (created by Context.Consumer)
in DataProvider (created by BootstrapTableContainer)
in BootstrapTableContainer
in Unknown (created by App)
in div (created by App)
in App

Example: https://stackblitz.com/edit/react-wjhzky?file=Hello.js

[AllenFang]

Hello @shhdharmen, so far the firstPageText only accept a string for customization. I will allow it to accept jsx in next version, thanks

[AllenFang]

@shhdharmen hello, this issue was fixed, please upgrade packages to newest version which listed in below:

https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2019/06/25/version-bump.html