Skip to content

Monitor less files by 'nodemon' with 'npm run docs' script#1198

Merged
taion merged 1 commit into
react-bootstrap:masterfrom
AlexKVal:nodemon
Aug 21, 2015
Merged

Monitor less files by 'nodemon' with 'npm run docs' script#1198
taion merged 1 commit into
react-bootstrap:masterfrom
AlexKVal:nodemon

Conversation

@AlexKVal

Copy link
Copy Markdown
Member

Why do we need to monitor node_modules in the first place ?

It will allow to get rid of
screen shot 2015-08-21 at 8 21 20 pm
and make less load to CPU

@taion

taion commented Aug 21, 2015

Copy link
Copy Markdown
Member

Might make sense in case someone upgrades a dependency while running the server? I don't know.

@AlexKVal

Copy link
Copy Markdown
Member Author

It seems I need to ask this question to @mtscout6

Why do we need to monitor node_modules in the first place ?

Do we need them to monitor now ?

@mtscout6

Copy link
Copy Markdown
Member

At the time I was frequently updating dependencies and wanting to see their affects on the docs. Though now that may not be the case. I'm ok with removing it, if the need arises again we can consider adding a cli flag to turn it on explicitly. (This should save my battery life when I forget that npm run docs is running in some unseen terminal 😄)

@taion

taion commented Aug 21, 2015

Copy link
Copy Markdown
Member

Cool!

taion added a commit that referenced this pull request Aug 21, 2015
Monitor less files by 'nodemon' with 'npm run docs' script
@taion
taion merged commit 93585dc into react-bootstrap:master Aug 21, 2015
@AlexKVal
AlexKVal deleted the nodemon branch August 22, 2015 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants