Fixes a bug in the fade mixin when providing a container - #241
Merged
pieterv merged 2 commits intoOct 14, 2014
Conversation
…o append a div to document.body
Member
Author
|
bump |
Contributor
|
Hey @mtscout6, sorry for the slow reply! Im happy with this, will merge it in and we can remove or move the css snippet if it becomes confusing! Thanks for this. |
pieterv
added a commit
that referenced
this pull request
Oct 14, 2014
Fixes a bug in the fade mixin when providing a container
Member
Author
|
Thanks, and no worries about the delay I understand we all get swamped at times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in the FadeMixin that prevents you from embedding it within a container.
I have also included an example of a contained modal. We did have to use some css to make sure that the modal was actually popped within the container which I have highlighted in the docs. If that's a stretch to include in this library, then I'll understand removing it from the docs, but the FadeMixin fix should still make it in.