fix: Call passed onKeyDown in all cases when handling keydown event #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 92.83% 92.93% +0.10%
==========================================
Files 4 4
Lines 265 269 +4
Branches 91 93 +2
==========================================
+ Hits 246 250 +4
Misses 19 19
Continue to review full report at Codecov.
|
Member
|
Could you add test case? |
Contributor
Author
|
Sure, I'll have a look at it later today |
Contributor
Author
|
@afc163 Added a test, let me know if it looks good to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the caller to also handle the keys that returned early (eg. Escape) and stopPropagation on them, for example.