Skip to content

chore: remove unused dependencies #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

chore: remove unused dependencies #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"@rc-component/np": "^1.0.4",
"@testing-library/jest-dom": "^6.1.4",
"@testing-library/react": "^16.3.0",
"@testing-library/user-event": "^14.5.2",
Copy link

@gemini-code-assist gemini-code-assist bot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this dependency is currently unused, it's worth noting that @testing-library/user-event is generally recommended over fireEvent for simulating user interactions in tests. The project's tests currently use fireEvent (e.g., in tests/index.spec.tsx), which doesn't simulate real user behavior as closely as user-event does. For example, userEvent.click() fires pointer events, hover events, and focus/blur events, which fireEvent.click() does not.

For more robust and reliable tests, I'd recommend considering re-adding this dependency and refactoring your tests to use userEvent. If you decide to stick with fireEvent, then removing this dependency is fine.

"@types/jest": "^29.4.0",
"@types/node": "^24.2.0",
"@types/react": "^19.1.4",
Expand Down