refactor: use renderable guards for input adornments - #203
Conversation
|
@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Walkthrough本次变更将节点渲染判断统一为 Changes可渲染节点判断
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Adornment values such as numeric 0 will render consistently while existing layout behavior stays aligned with rendered nodes. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 98.34% 98.36% +0.01%
==========================================
Files 11 11
Lines 423 428 +5
Branches 137 134 -3
==========================================
+ Hits 416 421 +5
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yoyo837
left a comment
There was a problem hiding this comment.
Reviewed the renderability semantics, helper selection, dependency floor, existing feedback, and completed CI results. The implementation looks correct. The Vercel failure is limited to team deployment authorization and is not a code or build failure.
说明
isReactRenderable统一判断 prefix、suffix、addon 和 clear icon 是否需要渲染0等有效 React 内容,并保持相关布局 class 与节点判断一致@rc-component/util的最低版本提升到首次提供该 helper 的^1.13.0验证
npm run tscnpm run lintnpm test -- tests/BaseInput.test.tsx tests/index.test.tsx --runInBandSummary by CodeRabbit