Skip to content

Conversation

yutingzhao1991
Copy link

@vercel
Copy link

vercel bot commented Jul 31, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-steps-git-feat-nav.react-component.now.sh

@coveralls
Copy link

coveralls commented Jul 31, 2019

Coverage Status

Coverage increased (+1.9%) to 74.021% when pulling c964e90 on feat/nav into 75f45fb on master.

@yutingzhao1991
Copy link
Author

修改了 dom 结构之后通过 css 样式可以实现如下的效果:

image

这个改动会影响 antd 那边的样式,到时候需要 antd 也同步做下调整。

@zombieJ
Copy link
Member

zombieJ commented Jul 31, 2019

@afc163
Copy link
Member

afc163 commented Jul 31, 2019

image

点击响应的区域有问题,点击上面区域,跳到了 1。

建议只有蓝线区域才有手型和对应的点击操作。

@yutingzhao1991
Copy link
Author

@afc163 处理了,把点击区域修改为 -item-container 这个范围内。

image

@yutingzhao1991 yutingzhao1991 changed the title feat: add active class and container dom feat: add active class and container dom and support disabled prop Aug 2, 2019
@yutingzhao1991
Copy link
Author

@zombieJ 新增了一个 disabled

@yutingzhao1991 yutingzhao1991 changed the title feat: add active class and container dom and support disabled prop feat: add active class and container dom and support disabled, subTitle prop Aug 2, 2019
@yutingzhao1991 yutingzhao1991 changed the title feat: add active class and container dom and support disabled, subTitle prop feat: add type, disabled, subTitle prop to support navigation step Aug 2, 2019
@yutingzhao1991
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants