New API: column.footer to render an extra footer row inside table
#195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I didn't give any distinctive apprearence to this newly added footer row, because I'm not sure how would you like to manage the css classname collision problem. We now have two "footer" things, and the DOM structure is also altered, the original css selector choice need a review. Also not sure if you want a corresponding Things like that are more of design preference rather than implementation problem, so I think I should leave these to you. |
Member
|
@hackape Could you fix the lint errors? |
Contributor
Author
|
lint problem fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update on previous PR #191 at @yesmeck's suggestion.
See discussion here: ant-design/ant-design#5710 (comment)