Skip to content

Conversation

shaodahong
Copy link
Member

@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/f243p84r6
✅ Preview: https://table-git-fix-sticky-with-fixed-columns.react-component.vercel.app

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #510 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          25       25           
  Lines         757      762    +5     
  Branches      217      220    +3     
=======================================
+ Hits          756      761    +5     
  Misses          1        1           
Impacted Files Coverage Δ
src/Table.tsx 100.00% <ø> (ø)
src/context/TableContext.tsx 100.00% <ø> (ø)
src/utils/fixUtil.ts 100.00% <ø> (ø)
src/Cell/index.tsx 98.38% <100.00%> (+0.02%) ⬆️
src/Header/FixedHeader.tsx 100.00% <100.00%> (ø)
src/stickyScrollBar.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d96b2...a775237. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Aug 4, 2020

加个用例吧~

@shaodahong shaodahong changed the title [WIP]fix: sticky with fixed columns fix: sticky with fixed columns Aug 4, 2020
@shaodahong
Copy link
Member Author

  1. 修复 sitcky 结合 scroll.y 造成滚动条宽度计算不准确
  2. 修复 siticky 结合 scroll.y 头部偏移位置
  3. 修复 siticky 结合 scroll.y 缺少 border-right
  4. 增加 active 的样式

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 4, 2020

This pull request introduces 1 alert when merging 3383884 into 86d96b2 - view on LGTM.com

new alerts:

  • 1 for Ambiguous HTML id attribute

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 4, 2020

This pull request introduces 1 alert when merging 18a36ac into 86d96b2 - view on LGTM.com

new alerts:

  • 1 for Ambiguous HTML id attribute

@vercel vercel bot temporarily deployed to Preview August 4, 2020 07:36 Inactive
@zombieJ zombieJ merged commit 26bacd3 into master Aug 4, 2020
@zombieJ zombieJ deleted the fix-sticky-with-fixed-columns branch August 4, 2020 12:49
@zombieJ
Copy link
Member

zombieJ commented Aug 4, 2020

+ rc-table@7.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants