fix: crashs when expandable.fixed without specifying 'scroll' property #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/table/7vM91XXz9K5ovM3HKmqx2v58Rb8b |
|
👏👏👏 |
|
来个测试用例 |
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 35 35
Lines 978 979 +1
Branches 279 279
=======================================
+ Hits 972 973 +1
Misses 6 6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
src/Table.tsx
Outdated
| } | ||
| scrollTableStyle = { | ||
| width: scroll.x === true ? 'auto' : scroll.x, | ||
| width: horizonScroll ? (scroll.x === true ? 'auto' : scroll.x) : 'auto', |
There was a problem hiding this comment.
应该直接在这一行加一个
scroll && scroll.x 就可以了
There was a problem hiding this comment.
Thanks！这样会减少逻辑改动。直接这么改TS会报类型错误，我稍修改了一下然后新开了一个PR
Barrywww
force-pushed
the
fix-expandable-crash
branch
from
6164731 to
925ff71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复了issue#755第一点提及的问题。
antd的官方文档中并未提及expandable.fixed 和 scroll 两属性需要同时设置，因此将scroll属性置空不应导致整个table crash。采用了默认的auto方式设置水平方向的scroll。