Skip to content

Conversation

Barrywww
Copy link
Contributor

采用了Junlin-Tommy在原PR提出的修改方案,减少对代码逻辑的改动。补充了测试用例。

修复了issue#755第一点提及的问题。

antd的官方文档中并未提及expandable.fixed 和 scroll 两属性需要同时设置,因此将scroll属性置空不应导致整个table crash。采用了默认的auto方式设置水平方向的scroll。

@vercel
Copy link

vercel bot commented Mar 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/F469NVcFEFdwQtMU2KThW5ghoCmZ
✅ Preview: https://table-git-fork-barrywww-fix-expandable-crash-react-component.vercel.app

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #765 (5f178ee) into master (925ff71) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #765   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          35       35           
  Lines         978      978           
  Branches      279      279           
=======================================
  Hits          972      972           
  Misses          6        6           
Impacted Files Coverage Δ
src/Table.tsx 99.17% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Co-authored-by: afc163 <afc163@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
@Barrywww
Copy link
Contributor Author

@afc163 多谢指正!如果3个commit比较乱的话... 需要我rebase成1个force-push上来吗?

@afc163
Copy link
Member

afc163 commented Mar 18, 2022

不需要,合并了会 squash 掉

@afc163 afc163 merged commit 17d2d27 into react-component:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants