chore: migrate to @rc-component namespace and update #662
Conversation
|
Someone is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded@EmilyyyLiu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 52 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Walkthrough该变更将包名与导入路径从 Changes
Sequence Diagram(s)(未生成 — 变更仅为包名/导入/配置迁移，控制流无显著变化) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a comprehensive migration of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 6 6
Lines 301 301
Branches 78 82 +4
=======================================
Hits 268 268
Misses 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
直接在这个里面classNames换clsx? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
package.json (4)
20-22: 补充 types 字段，提升 TS 消费者体验father 会输出声明文件，但未显式声明
types。建议指向 ES 入口的 d.ts。"main": "./lib/index", "module": "./es/index", + "types": "./es/index.d.ts",
32-32: 移除遗留的 now 构建脚本
now.json已删除，now-build脚本可一并移除，避免混淆。- "now-build": "npm run docs:build",
33-33: 发布流程小提示
prepublishOnly里使用rc-np已对齐组织内规范。若仓库启用 CI 自动发布，建议在 README/CONTRIBUTING 中注明发布方式与需要的 NPM Token 权限，降低维护成本。
40-42: 关于classnames→clsx的迁移建议本 PR 目前只需保留对
classnames的依赖，后续另起 PR 全量切换至官方clsx包；若决定本次合并一并升级，请将 src/AjaxUploader.tsx 第 2 行-import clsx from 'classnames'; +import clsx from 'clsx';替换并验证行为一致。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
.dumirc(1 hunks)README.md(5 hunks)docs/examples/asyncAction.tsx(1 hunks)docs/examples/beforeUpload.tsx(1 hunks)docs/examples/customRequest.tsx(1 hunks)docs/examples/directoryUpload.tsx(1 hunks)docs/examples/drag.tsx(1 hunks)docs/examples/dragDirectory.tsx(1 hunks)docs/examples/paste.tsx(1 hunks)docs/examples/pasteDirectory.tsx(1 hunks)docs/examples/simple.tsx(1 hunks)docs/index.md(1 hunks)now.json(0 hunks)package.json(2 hunks)tsconfig.json(1 hunks)
💤 Files with no reviewable changes (1)
- now.json
🔇 Additional comments (12)
docs/examples/directoryUpload.tsx (1)
4-4: 导入路径更新👍
顺利切换到 @rc-component 上传组件命名空间，此处示例可继续正常运行。docs/examples/pasteDirectory.tsx (1)
3-3: 导入重命名已对齐
示例同步指向新包，保持与仓库其余部分一致，无需额外改动。docs/examples/drag.tsx (1)
3-3: 导入路径迁移确认
这里的替换与整体迁移策略一致，示例逻辑不受影响。docs/examples/simple.tsx (1)
3-3: 类型与组件导入同步良好
Upload及UploadProps一并指向新命名空间，类型推断依旧可用。docs/examples/dragDirectory.tsx (1)
3-3: 导入替换完成
示例中的组件来源已成功对接 @rc-component/upload，与其他文件保持一致。docs/examples/asyncAction.tsx (1)
3-3: 导入路径更新 OK异步 action 示例仅变更路径，无行为改动。与 tsconfig/dumi alias 一致即可。
docs/examples/beforeUpload.tsx (1)
4-4: 示例导入路径已切换至 @rc-component/upload
所有示例均已更新，无“rc-upload”导入残留。请本地运行 dumi 文档以验证示例编译通过。tsconfig.json (1)
11-13: alias 已同步更新.dumirc配置中未发现rc-upload，已全部替换为@rc-component/upload，无需额外修改。docs/examples/paste.tsx (1)
3-3: 无遗留rc-upload模块导入已使用 ripgrep 验证仓库内所有
.js/.jsx/.ts/.tsx文件，不存在from 'rc-upload'或require('rc-upload')的引用，可安心合并。.dumirc (1)
6-7: 命名空间别名更新合理
Line 6-7 的 alias 已和新的包名保持一致，示例与文档依赖能够顺利解析到源码路径，符合本次迁移目标。docs/index.md (1)
1-3: 文档标题同步正确
Line 2 的标题更新与包名迁移保持一致，可确保 dumi 站点展示的新名称。docs/examples/customRequest.tsx (1)
4-4: 示例组件引用已更新
Line 4 的导入路径已经切换到新命名空间，示例可直接复用无需额外改动。
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
3 participants
迁移rc-upload 到 @rc-component 空间
Summary by CodeRabbit