-
Notifications
You must be signed in to change notification settings - Fork 930
[Feat] Add support for .xcode.env file in init and doctor commands #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import {HealthCheckInterface} from '../../types'; | ||
| import fs from 'fs'; | ||
| import path from 'path'; | ||
| import {promisify} from 'util'; | ||
| import {findProjectRoot} from '@react-native-community/cli-tools'; | ||
| import {findPodfilePaths} from '@react-native-community/cli-platform-ios'; | ||
|
|
||
| const xcodeEnvFile = '.xcode.env'; | ||
| const pathSeparator = '/'; | ||
|
|
||
| function removeLastPathComponent(pathString: string): string { | ||
| const components = pathString.split(pathSeparator); | ||
| components.splice(components.length - 1, 1); | ||
| return components.join(pathSeparator); | ||
| } | ||
|
|
||
| function pathHasXcodeEnvFile(pathString: string): boolean { | ||
| const xcodeEnvPath = pathString + pathSeparator + xcodeEnvFile; | ||
| return fs.existsSync(xcodeEnvPath); | ||
| } | ||
|
|
||
| function pathDoesNotHaveXcodeEnvFile(pathString: string): boolean { | ||
| return !pathHasXcodeEnvFile(pathString); | ||
| } | ||
|
|
||
| export default { | ||
| label: '.xcode.env', | ||
| description: 'File to customize Xcode environment', | ||
| getDiagnostics: async () => { | ||
| const projectRoot = findProjectRoot(); | ||
| const allPathsHasXcodeEnvFile = findPodfilePaths(projectRoot) | ||
| .map((pathString) => { | ||
| const basePath = removeLastPathComponent(pathString); | ||
| return pathHasXcodeEnvFile(basePath); | ||
| }) | ||
| .reduce((previousValue, currentValue) => previousValue && currentValue); | ||
| return { | ||
| needsToBeFixed: !allPathsHasXcodeEnvFile, | ||
| }; | ||
| }, | ||
| runAutomaticFix: async () => { | ||
| const templateXcodeEnv = '_xcode.env'; | ||
| const projectRoot = findProjectRoot(); | ||
|
|
||
| const templateIosPath = path.dirname( | ||
| require.resolve('react-native/template/ios'), | ||
| ); | ||
|
|
||
| const src = templateIosPath + templateXcodeEnv; | ||
| const copyFileAsync = promisify(fs.copyFile); | ||
|
|
||
| findPodfilePaths(projectRoot) | ||
| .map(removeLastPathComponent) | ||
| // avoid overriding existing .xcode.env | ||
| .filter(pathDoesNotHaveXcodeEnvFile) | ||
| .forEach(async (pathString) => { | ||
| const destFilePath = pathString + pathSeparator + xcodeEnvFile; | ||
| await copyFileAsync(src, destFilePath); | ||
| }); | ||
| }, | ||
| } as HealthCheckInterface; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| */ | ||
| import glob from 'glob'; | ||
|
|
||
| // These folders will be excluded from search to speed it up | ||
| const GLOB_EXCLUDE_PATTERN = ['**/@(Pods|node_modules|Carthage)/**']; | ||
|
|
||
| export default function findAllPodfilePaths(cwd: string) { | ||
| return glob.sync('**/Podfile', { | ||
| cwd, | ||
| ignore: GLOB_EXCLUDE_PATTERN, | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat unrelated (and definitely not to be fixed in this PR), I looked briefly at the options that are passed to all CLI commands and it looks like they include this information. However, it doesn't look like they are properly forwarded to the individual fixers. It's a bit silly that we have to duplicate the effort to find this info again. Do we have an issue tracking this? cc @mikehardy @thymikee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we track this. Would make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #1588