chore: fix tests on Windows #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
fix/windows
branch
5 times, most recently
from
4173154 to
f3c75d1
Compare
Member
Author
|
@Esemesek feel free to jump on the last 2 failing tests:
|
Member
Author
|
@theweavrs it would be lovely if you could help me finish this PR up! <3 |
Contributor
|
@thymikee sure, how can I help? |
Member
Author
|
By fixing the tests that are still failing and sending a PR to this branch ( |
* use stringify with replacer * use slash * fix: rnpm deprecation test * fix: copyFiles test in windows * fix: e2e tests on windows * fix: init from local template * fix: cli getting stuck on replacing project dir * fix: properly escape regexp when copying template * refactor: use escape func from jest-regex-util * refactor: copy escape func from jest-regex-util
Member
Author
|
Thank you @theweavrs ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
An attempt to fix the tests on Windows.
Test Plan:
Green CI