Doctor/windows #675
Merged
Doctor/windows #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeistrich
requested review from
Esemesek,
grabbou and
thymikee
as code owners
tido64
reviewed
Sep 4, 2019
| : 'sdkmanager --list', | ||
| (err, stdout) => { | ||
| if (err) { | ||
| resolve('Not Found'); |
Member
There was a problem hiding this comment.
I was wondering same thing. This probably should be reject.
|
|
||
| return { | ||
| needsToBeFixed: | ||
| (sdks === 'Not Found' && installMessage) || |
Contributor
There was a problem hiding this comment.
Can we make 'Not Found' a constant or make sdks undefined instead?
Esemesek
reviewed
Sep 4, 2019
| ? { | ||
| 'Build Tools': matches, | ||
| } | ||
| : 'Not Found', |
Member
There was a problem hiding this comment.
Not Found is resolved here as well.
Contributor
Author
|
I changed it to reject on failure and set sdks to 'Not Found' in the catch so it's just in one place. Is this better? I don't think it should make |
thymikee
reviewed
Sep 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes multiple issues on Windows:
Test Plan:
Run
doctoron a Windows machine with no Android SDKs installed to see #1, and then install Android SDKs and see that it was still showing an error.