Skip to content

chore: converted install command to typescript #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2019
Merged

chore: converted install command to typescript #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe4a2a8
chore: converted install command to typescript
Quadriphobs1 Sep 10, 2019
d71e198
Merge branch 'master' into chore/typescript-install-command
Quadriphobs1 Sep 10, 2019
0f16f94
fix eslints
Quadriphobs1 Sep 10, 2019
913a822
remove eslint silent comment
Quadriphobs1 Sep 10, 2019
3f12d97
disable eslint for concerned line
Quadriphobs1 Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/cli/src/commands/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ import ramBundle from './bundle/ramBundle';
import link from './link/link'; // eslint-disable-line import/namespace, import/default
// @ts-ignore - JS file
import unlink from './link/unlink'; // eslint-disable-line import/namespace, import/default
// @ts-ignore - JS file
import install from './install/install'; // eslint-disable-line import/namespace, import/default
// @ts-ignore - JS file
import uninstall from './install/uninstall'; // eslint-disable-line import/namespace, import/default
import install from './install/install';
import uninstall from './install/uninstall';
import upgrade from './upgrade/upgrade';
import info from './info/info';
// @ts-ignore - JS file
Expand Down
12 changes: 5 additions & 7 deletions packages/cli/src/commands/install/install.js → packages/cli/src/commands/install/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,15 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
*/

import type {ConfigT} from 'types';
import {logger} from '@react-native-community/cli-tools';
// $FlowFixMe - converted to TS
import * as PackageManager from '../../tools/packageManager';
import link from '../link/link';
import loadConfig from '../../tools/config';
// @ts-ignore FIXME after converting link/link
import link from '../link/link'; // eslint-disable-line import/namespace, import/default
// @ts-ignore FIXME after converting tools/config
import loadConfig from '../../tools/config'; // eslint-disable-line import/namespace, import/default

async function install(args: Array<string>, ctx: ConfigT) {
async function install(args: Array<string>): Promise<void> {
const name = args[0];

logger.info(`Installing "${name}"...`);
Expand Down
10 changes: 4 additions & 6 deletions ...ges/cli/src/commands/install/uninstall.js → ...ges/cli/src/commands/install/uninstall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,14 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
*/

import type {ConfigT} from 'types';
import {Config} from '@react-native-community/cli-types';
import {logger} from '@react-native-community/cli-tools';
// $FlowFixMe - converted to TS
import * as PackageManager from '../../tools/packageManager';
import unlink from '../link/unlink';
// @ts-ignore FIXME after converting link/unlink
import unlink from '../link/unlink'; // eslint-disable-line import/namespace, import/default

async function uninstall(args: Array<string>, ctx: ConfigT) {
async function uninstall(args: Array<string>, ctx: Config): Promise<void> {
const name = args[0];

logger.info(`Unlinking "${name}"...`);
Expand Down