doctor: improve CocoaPods installation #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbento
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Closed
Member
Author
|
@thib92: I would appreciate if you could check the code, I did some stuff to get TypeScript work. |
thib92
approved these changes
Sep 13, 2019
Contributor
thib92
left a comment
thib92
left a comment
There was a problem hiding this comment.
Apart from this one comment, looks good to me 👍
tido64
reviewed
Sep 15, 2019
added 4 commits
September 16, 2019 09:54
…into refactor/separate-cocoapods-installation
Member
Author
thymikee
reviewed
Sep 17, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Looks good, left some inline feedback
Member
Author
|
@thymikee: all fixed 🙂 |
thymikee
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a small problem on the UI of
doctorwith the CocoaPods installation (tracked at #694), however it introduced a lot of stuff in the code in order to get it done.The issue basically was that the question was being shown in the middle of the fixes and felt a little bit out-of-place, the idea was to remove the question and do the installation together with a prefix of the method, e.g.
CocoaPods (installing with gem).This turned out to be slightly bigger than expected, in order to remove the question after it's prompted I had to calculate the length of lines the question was using in the terminal.
Before
After
Test Plan:
sudo gem uninstall cocoapodsnode /path/to/cli doctorf