fix: Properly handle --host param for remote debugging #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The snapshot test failure seems unrelated to my change? |
thymikee
approved these changes
Oct 26, 2019
thymikee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When running metro on one machine and a react-native app on another, /launch-js-devtools causes the metro process to launch localhost:8081. However, the hostname can be overridden by the --host parameter to react-native start, which because of the hardcoding of localhost, causes the web debugger to not start, breaking the react-native app.
Test Plan:
Manually verified that the RN app can run when running react-native start with both: no params as well as --host