Skip to content

fix: Properly handle --host param for remote debugging #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2019
Merged

fix: Properly handle --host param for remote debugging #829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c3cc1
Properly handle --host param for remote debugging
Oct 26, 2019
b40044d
linting
Oct 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/cli/src/commands/server/middleware/getDevToolsMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ import {logger} from '@react-native-community/cli-tools';
import {exec} from 'child_process';
import launchDebugger from '../launchDebugger';

function launchDefaultDebugger(port: number, args = '') {
const debuggerURL = `http://localhost:${port}/debugger-ui${args}`;
function launchDefaultDebugger(host: string, port: number, args = '') {
const hostname = host || 'localhost';
const debuggerURL = `http://${hostname}:${port}/debugger-ui${args}`;
logger.info('Launching Dev Tools...');
launchDebugger(debuggerURL);
}
Expand All @@ -20,10 +21,14 @@ function escapePath(pathname: string) {
return `"${pathname}"`;
}

type LaunchDevToolsOptions = {port: number; watchFolders: Array<string>};
type LaunchDevToolsOptions = {
host: string;
port: number;
watchFolders: Array<string>;
};

function launchDevTools(
{port, watchFolders}: LaunchDevToolsOptions,
{host, port, watchFolders}: LaunchDevToolsOptions,
isDebuggerConnected: () => boolean,
) {
// Explicit config always wins
Expand All @@ -32,7 +37,7 @@ function launchDevTools(
startCustomDebugger({watchFolders, customDebugger});
} else if (!isDebuggerConnected()) {
// Debugger is not yet open; we need to open a session
launchDefaultDebugger(port);
launchDefaultDebugger(host, port);
}
}

Expand Down